Waleed Khan

Results 200 comments of Waleed Khan

Thanks for looking into this! Can we try instead implementing this logic in `core::check_out::check_out_commit`? That way, we can benefit from this behavior in other places too. > My Rust is...

Also, I added a refactoring for the checkout target in https://github.com/arxanas/git-branchless/pull/514 which might help, so you may want to rebase your work on top of that.

My bet is that you just need to apply this patch: ```diff diff --git a/git-branchless/tests/command/test_navigation.rs b/git-branchless/tests/command/test_navigation.rs index 3aa0d90..5eb0153 100644 --- a/git-branchless/tests/command/test_navigation.rs +++ b/git-branchless/tests/command/test_navigation.rs @@ -859,6 +859,7 @@ fn test_checkout_auto_switch_interactive() ->...

Other than the failing tests, everything looks good to me. When you're done, please squash and force-push your changes and I'll merge this PR. Thanks for working on this!

We have some failing Nix tests already for PTY-related stuff, so I just added the new failing tests introduced in this PR to the list of skipped tests. @bcspragu thanks...

Thanks for reporting. I guess I didn't imagine people using `#` in branch names since it usually has special meaning in the shell. As a workaround, can you add an...

Will respond later but in the meantime you can try disabling working copy snapshotting https://github.com/arxanas/git-branchless/wiki/Configuration#branchlessundocreatesnapshots

Hi @elipsitz, thanks for reporting. Yep, we definitely don't have submodule support at the moment. That being said, it sounds like there's only one reasonable interpretation of a snapshot of...

To clarify why this is happening, `git-branchless` tries to take a snapshot of the working copy state before carrying out operations which modify the working copy, so that you can...

Ah, I forgot about this. The idea from an implementation perspective is to always capture snapshots to represent the working copy, rather than using some other representation of the working...