Waleed Khan

Results 200 comments of Waleed Khan

> Other than post-rewrite I don't know if these hooks are run normally during a rebase. The rules are really arbitrary for `git rebase`. For example, if you `reword` a...

I responded to this effect at https://github.com/martinvonz/jj/pull/2914, but I don't think the test compilation time by itself is what we should be optimizing for, but rather the total test runtime...

Shall we close this? We now bundle scm-record into jj, and we can invoke external diff editors as desired. It's true that scm-record doesn't let you edit hunks directly, which...

@bergkvist One alternative is what I do: I never use `jj git` and simply use `git` for all clone/fetch/push operations, and use jj's colocated repo mode to use jj with...

I think I've said this somewhere on Discord, but my vote would be for `jj rebase` to not do automatic commit dropping, and instead reserve that for `jj sync` or...

Update from @epage on signing commits with libgit2: https://github.com/arxanas/git-branchless/issues/465#issuecomment-1372379421

If someone implements GC, it would also be a good time to "compact" the keep refs (assuming that jj doesn't already do that). Some Git operations scale with the number...

@ilyagr I mention it because, at my work, [a certain Phabricator script](https://phabricator.wikimedia.org/source/arcanist/browse/wmf%252Fstable/src/land/engine/ArcanistGitLandEngine.php;953d742a1a9bb8520c4d7cd8ba77ea5e1519a866$61) invokes `git for-each-ref --contains X`, which hangs because I have 100k (packed) git-branchless refs 😄.

> Since Git 2.38 rebase has a new option --update-refs that git-revise could mimick eventually? I think that's the best approach. In fact, I don't think it even needs to...

I'm not a maintainer of this project, but my guess is that nobody has needed these functions, and so nobody has implemented bindings for them. As a workaround, you could...