gitmoji-commit-workflow icon indicating copy to clipboard operation
gitmoji-commit-workflow copied to clipboard

Commitlint plugin does not recognize ⬆️

Open jpolo opened this issue 2 years ago • 3 comments

The bug concerns the commitlint plugin/config.

I usea custom config available in this repository. It is possible to reproduce the bug by changing the value of anyGitmoji to '⬆️'.

The validation message is "Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/."

jpolo avatar Jun 23 '22 19:06 jpolo

Could reproduce with 🩹, so it seems to be a wider problem...

jpolo avatar Jun 24 '22 20:06 jpolo

It seems that using is-fullwidth-code-point And replacing the unicodeRegex with unicodeResult = raw.split('').filter(isFullwidthCodePoint); would validate the commit message. Would you accept a PR, or is this repo dead ?

jpolo avatar Aug 12 '22 20:08 jpolo

I have the same problem with 🧪 and 🏗️.

I found this regex (line 10) and I made a list of all emojis based on this json and a lot of emojis doesn't match with this regex.

Sample: https://regex101.com/r/BS5M9a/1

This regex work as well: https://regex101.com/r/R7drml/2 but I'm not sure about this solution.

srizzon avatar Aug 19 '22 21:08 srizzon

I found this as well, and I think this project is dead :/

mehdicopter avatar Oct 13 '22 15:10 mehdicopter

fixed in [email protected]

arvinxx avatar Feb 10 '23 16:02 arvinxx