libtorrent icon indicating copy to clipboard operation
libtorrent copied to clipboard

Fix wrong variable in CMake

Open Chocobo1 opened this issue 10 months ago • 5 comments

The Windows variable is not defined in CMake. The correct variable should be MSVC. https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html#variables-that-describe-the-system

Chocobo1 avatar Jun 03 '25 16:06 Chocobo1

@Chocobo1 Do you know why the Windows build in this repo (in-general) always show a green tick overall even when there's been a failure of say even 1 test?

xavier2k6 avatar Jun 03 '25 16:06 xavier2k6

@Chocobo1 Do you know why the Windows build in this repo (in-general) always show a green tick overall even when there's been a failure of say even 1 test?

Not familiar with libtorrent CI workflow but it seems to be from this line: https://github.com/arvidn/libtorrent/actions/runs/15422437022/workflow?pr=7951#L21

Chocobo1 avatar Jun 03 '25 16:06 Chocobo1

It look like your fix broke the Windows CI run. Perhaps more fixes are needed?

petterreinholdtsen avatar Jun 05 '25 06:06 petterreinholdtsen

It look like your fix broke the Windows CI run. Perhaps more fixes are needed?

How do I fix it?

Chocobo1 avatar Jun 05 '25 07:06 Chocobo1

It look like your fix broke the Windows CI run.

Doesn't seem that they are related.

glassez avatar Jun 05 '25 07:06 glassez