use retry for macOS simulations

Open AllSeeingEyeTolledEweSew opened this issue 3 years ago • 3 comments

The simulations on macOS are flaky. Let's use a retry loop for them.

Sep 11 '22 17:09 AllSeeingEyeTolledEweSew

The flakiness of this test on MacOS is caused by a problem in the simulator. Something is not deterministic. I believe I've fixed these issues in RC_2_0 and later. I would like those more recent branches to fail if some non-determinism is introduced again.

Sep 14 '22 11:09 arvidn

so, I'm hesitant to land this. It would be better to back-port the determinism fixes

Sep 14 '22 11:09 arvidn

IMO this isn't any worse than ignoring a CI failure, but sure, backporting is great.

I'll take a crack at backporting these fixes, if you can tell me how I can identify them.

Sep 14 '22 16:09 AllSeeingEyeTolledEweSew

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Dec 26 '22 08:12 stale[bot]