libtorrent icon indicating copy to clipboard operation
libtorrent copied to clipboard

Add a pre-commit autoupdate cron job

Open AllSeeingEyeTolledEweSew opened this issue 3 years ago • 5 comments

This will auto-generate PRs to update our pre-commit hooks.

On my fork, it auto-generated this PR:

  • https://github.com/AllSeeingEyeTolledEweSew/libtorrent/pull/48

I believe the scheduled workflow will only run once this change is merged to RC_2_0.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 11 '22 03:06 stale[bot]

bump

what does it mean to update a "pre commit hook"? is it about modifying the pre commit config to specify new version numbers?

arvidn avatar Jun 12 '22 17:06 arvidn

Yes. It's analogous to updating pinned versions of github actions, e.g. actions/setup-python@v3 to actions/setup-python@v4.

In practice the most common side effect of these updates is new complaints from mypy, where there was a legitimate typing error in our code but mypy only notices it on a version bump.

@arvidn FYI: libtorrent's pre-commit config currently breaks if run with python 3.7+. Currently the CI job uses python 3.6 which happens to work, but that version is EOL and should be bumped.

We need a pre-commit autoupdate run to fix it. Or merge this PR, and it will automatically generate PRs with pre-commit autoupdate.

IMO, this kind of thing is exactly the reason to auto-update dependencies, even for CI. It seems much better to make incremental updates as parts of the environment change over time, rather than try to update a bunch of stuff at once when something breaks.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 26 '22 08:12 stale[bot]