Arvid Norberg
Arvid Norberg
I agree that would be useful information in the tracker alerts. It’s easy to add, however, it’s an ABI break on the C++ side. it could be done with a...
Adding fields at the end of the class should be fine. Those objects are always allocated by libtorrent and only accessed through pointers. The risk is a client built against...
looking into this; the `tracker_alert` derives from `torrent_alert` which already has a `handle` member, which is the `torrent_handle` to the corresponding torrent. As far as I can tell, the only...
how does this look? https://github.com/arvidn/libtorrent/pull/6877
> It looks incomplete. You mean because I didn't add the field to the scrape alerts?
I see. This is where the protocol version is added to the `tracker_reply_alert`: https://github.com/arvidn/libtorrent/pull/6877/files#diff-a17ad09f87450b4293a08e2811c13e572239db6a0bd378d22291a79fd1f5f072R3517
> But still, what about the rest of tracker alerts? They shouldn't be changed? Then why is your comment about moving protocol version field in base tracker_alert? That comment is...
@zeule would it make sense to ignore prefix whenever the path is absolute?
my understanding is that it's the shell that expands `~`, and it wouldn't necessarily work anywhere else. Any path starting with `/` is absolute.
on windows it's a bit trickier, but it it sounds like cmake has built-in functionality for this: https://cmake.org/cmake/help/latest/command/cmake_path.html#append