mutex icon indicating copy to clipboard operation
mutex copied to clipboard

Add Predis timeout

Open antriver opened this issue 8 years ago • 4 comments
trafficstars

This adds the ability to set an expiration time on the lock when using the Predis Redis driver.

It follows the procedure recommended in the Redis docs here: https://redis.io/commands/setnx

antriver avatar Feb 27 '17 11:02 antriver

Hi @arvenil

Thanks for this package.

I see you've made some significant changes in master. If there is any chance of this PR getting merged I will update it to reflect those changes. Could you let me know if it's worth me spending the time on that?

Currently I have merged master into my branch but due to the changes it's broken and should not be merged.

Thanks, Anthony

antriver avatar Nov 14 '17 01:11 antriver

Few months ago I merged this PR manually ( you can see it from https://github.com/deminy/ninja-mutex ) and used it in some production environment for data migration (for tens of millions of records at least). Everything worked fine so I'd recommend to accept this PR. Thanks

deminy avatar Nov 14 '17 01:11 deminy

Hi @arvenil and @deminy I've remade this PR based on the latest master, and without the destructor/exception changes. Would you mind giving it another look?

antriver avatar Jul 16 '20 01:07 antriver

@antriver I'm ok with anything that doesn't brake tests, but travis test run is broken right now 🤷

arvenil avatar Jul 16 '20 18:07 arvenil