nginx-dav-ext-module icon indicating copy to clipboard operation
nginx-dav-ext-module copied to clipboard

Adding fake PROPPATCH to make windows happy

Open speq opened this issue 6 years ago • 9 comments

Hi All,

I added a patch to response PROPPATCH for windows. Let dav-ext work with windows explorer. Windows need LOCK and PROPPATCH to put a file.

proppatch.patch.gz

speq avatar Nov 12 '19 08:11 speq

IMO faking support is better than not supporting Windows at all,

but why do we need to fake it? is adding real support much more difficult or something? (i'm not complaining, i just honestly don't know the answer, i don't even know what PROPPATCH is supposed to do)

divinity76 avatar Nov 26 '19 08:11 divinity76

this is related to issue #18 (an issue that has been, in my opinion, erroneously closed)

divinity76 avatar Nov 26 '19 08:11 divinity76

Hi @divinity76, I'm not expert of WebDAV and real support takes times. It just worked well as a standalone web drive server for my personal use.

speq avatar Nov 30 '19 06:11 speq

i just skimmed through https://tools.ietf.org/html/rfc4918#section-9.2 , and concluded that adding proper PROPPATCH support is certainly non-trivial.

thanks for sharing!

divinity76 avatar Nov 30 '19 09:11 divinity76

For PROPPATCH there is a more simple way:

if ($request_method = PROPPATCH) { # Unsupported, allways return OK.
	add_header	Content-Type 'text/xml';
	return		207 '<?xml version="1.0"?><a:multistatus xmlns:a="DAV:"><a:response><a:propstat><a:status>HTTP/1.1 200 OK</a:status></a:propstat></a:response></a:multistatus>';
}

But for windows WebDAV clients you need more hacks: http://netlab.dhis.org/wiki/ru:software:nginx:webdav (see end of page - all in one hacks)

rozhuk-im avatar Mar 12 '20 21:03 rozhuk-im

thanks man @rozhuk-im

Alfagun74 avatar Nov 24 '20 20:11 Alfagun74

Did anyone get this working with the above suggestions?

aguaviva avatar Jan 16 '22 21:01 aguaviva

https://github.com/dgraziotin/docker-nginx-webdav-nononsense/issues/8

rozhuk-im avatar Jan 16 '22 21:01 rozhuk-im

Thank you!!!

aguaviva avatar Jan 17 '22 00:01 aguaviva