omniauth-twitter icon indicating copy to clipboard operation
omniauth-twitter copied to clipboard

authenticate / authorize behavior is now the same

Open ThisIsMissEm opened this issue 7 years ago • 2 comments

Previously if you used "authenticate", then if the twitter user had already authorized your app, you'd be redirect straight back to the application without user interaction. In a recent change they made "authenticate" behave the same as "authorize".

This results in the following changes:

  • README / documentation stating the behavior difference is incorrect
  • There is no difference, so there's no reason to switch between authenticate and authorize based on configuration. This would be a code change, deprecating the "authorize" feature.

I'm wondering how you'd like a pull request to make the appropriate changes / if you want those changes. I was a little confused why I was always getting the interstitial screen, no matter what my configuration was, and found this twitter change to be the answer. Rather than letting everyone slowly figure this out, I feel like it'd be better for me to contribute a change back to align things.

ThisIsMissEm avatar Nov 11 '17 17:11 ThisIsMissEm

You can make changes in your branch and then make PR

raysrashmi avatar Nov 23 '17 04:11 raysrashmi

@raysrashmi okay, so, you're onboard with the change?

ThisIsMissEm avatar Dec 25 '17 23:12 ThisIsMissEm