cpp-subprocess

cpp-subprocess copied to clipboard

MinGW support

1

MinGW (Min. GNU for Windows) also requires the Windows-specific code, but doesn't `#define` **_MSC_VER**. All the Windows-specific fixes are ignored. Using a combined definition would solve this.

deanmsands3

some functions are not inline

1

Some functions are not inline. This will cause multiple definition errors in projects that include your lib. Examples: ``` std::string get_last_error() FILE *file_from_handle(HANDLE h, const char *mode) void configure_pipe(HANDLE* read_handle,...

klosworks

Segfault when creating and closing lots of subprocesses

3

This behavior is seen in 126ee29. ## Steps to reproduce Compile and run the following program on a non-Windows system: ```c++ #include #include "subprocess.hpp" using namespace subprocess; int main(int argc,...

mplough

execute_child shouldn't use any signal-unsafe functions

2

I see the uses of std::string and setenv after fork. I believe these functions are unsafe, because after fork, the state of memory heap is undefined. I haven't been able...

yasushi-saito

Buffer class is badly designed and superfluous

2

The class Buffer has ``` std::vector buf; size_t length = 0; ``` This is a bad interface design because the `length` field duplicates the `buf.size()`. At what situations can those...

klosworks

design of Popen arguments promotes unsafe use

2

This is a design issue. Basically there is a problem with definitions like this: ``` struct output { output(int fd): wr_ch_(fd) {} output (FILE* fp):output(fileno(fp)) { assert(fp); } output(const char*...

klosworks

You have a lot of static inline functions, such as ``` static inline std::vector split(const std::string& str, const std::string& delims=" \t") ``` The problem is, with static functions, the compiler...

klosworks

bug in util::join

2

The current definition is ``` static inline std::string join(const std::vector& vec, const std::string& sep = " ") { std::string res; for (auto& elem : vec) res.append(elem + sep); res.erase(--res.end()); return...

klosworks

I would expect this code: ``` using namespace subprocess; auto proc = Popen("ls fdklajfdlsajfdkljaf", error{PIPE}, cwd{where}, shell{true}); auto errors = proc.communicate().first; std::cerr

klosworks

It would not be a stretch to expect this: ``` auto proc = Popen(subprocess::util::split(command), error{PIPE}, cwd{where}); ``` to compile. Unfortunately it gives the following error: ``` /home/pklos/projects/(...).cpp:70:80: error: no matching...

klosworks