virt-backup icon indicating copy to clipboard operation
virt-backup copied to clipboard

Published 20 hours ago • verified publisher icon aruhier

adds sha1 hash to json

Open hruljov opened this issue 3 years ago • 3 comments

hruljov avatar Mar 23 '21 12:03 hruljov

Coverage Status

Coverage decreased (-0.8%) to 82.633% when pulling e1426fb80bcb692561018b40dfbd6d7f5b686075 on hruljov:master into bbcf5607ba00eebe443b2396f0b646191b3150c2 on aruhier:dev.

coveralls avatar Mar 23 '21 12:03 coveralls

Hi, Thanks a lot for your PR!

However I have an issue with the fact that each image disk will be read twice. I'm wondering if it would not be better to compute the hash in the packagers, when adding a file. The packagers could return a hash as a result.

aruhier avatar Mar 23 '21 20:03 aruhier

Need to look at the functional packagers

hruljov avatar Mar 24 '21 08:03 hruljov