aos-switch-ansible-collection icon indicating copy to clipboard operation
aos-switch-ansible-collection copied to clipboard

Published 20 hours ago • verified publisher icon aruba

Fix sanity pylint

Open alagoutte opened this issue 2 years ago • 4 comments

alagoutte avatar Aug 21 '22 13:08 alagoutte

Oups typo (wrong copy/paste) -> fixed

alagoutte avatar Aug 31 '22 19:08 alagoutte

Thank you for the contribution! At this time I have other obligations but I will review at my earliest convenience!

tchiapuziowong avatar Aug 31 '22 21:08 tchiapuziowong

Thank you for the contribution! At this time I have other obligations but I will review at my earliest convenience!

Sure ! no problem !

alagoutte avatar Sep 01 '22 12:09 alagoutte

Any news ?

alagoutte avatar Sep 13 '22 18:09 alagoutte

bump ? @tchiapuziowong @Keeper-of-the-Keys @karthikeyan-dhandapani

alagoutte avatar Jan 07 '23 13:01 alagoutte

@alagoutte I'm not able to do a review for you, I don't work for HP/Aruba, I also no longer work at a company that has Aruba equipment so can't check the changes in a real world environment.

But if it helps the changes do look OK to me...

Keeper-of-the-Keys avatar Jan 08 '23 07:01 Keeper-of-the-Keys

@alagoutte I'm not able to do a review for you, I don't work for HP/Aruba, I also no longer work at a company that has Aruba equipment so can't check the changes in a real world environment.

But if it helps the changes do look OK to me...

Oups sorry wrong ping mention !

alagoutte avatar Jan 08 '23 14:01 alagoutte

I'm working on publishing some fixes that development has been working on and I'll include this in the next release - goal is by end of week next week.

tchiapuziowong avatar Jan 26 '23 01:01 tchiapuziowong

I'm working on publishing some fixes that development has been working on and I'll include this in the next release - goal is by end of week next week.

Perfect,

a new series of patch

  • https://github.com/aruba/aos-switch-ansible-collection/pull/59
  • https://github.com/aruba/aos-switch-ansible-collection/pull/60
  • https://github.com/aruba/aos-switch-ansible-collection/pull/61
  • https://github.com/aruba/aos-switch-ansible-collection/pull/62
  • https://github.com/aruba/aos-switch-ansible-collection/pull/63

alagoutte avatar Jan 26 '23 08:01 alagoutte

Hey @alagoutte ! All the fixes for sanity: fix pylint ansible-format-automatic-specification have wrong indexes (starting at 1 instead of 0), which breaks it https://github.com/aruba/aos-switch-ansible-collection/commit/45f1379aa66b635d08f2e0fb28e95b365f913a73

SalutAToi avatar Jan 31 '23 10:01 SalutAToi

Hey @alagoutte ! All the fixes for sanity: fix pylint ansible-format-automatic-specification have wrong indexes (starting at 1 instead of 0), which breaks it 45f1379

Oups, i will push a fix...

alagoutte avatar Jan 31 '23 15:01 alagoutte