Andrew Twyman

Results 115 comments of Andrew Twyman

Oh, I didn't realize const style customization was an internal feature you were simply exposing. Makes more sense now, thanks. Which other ident styles were you using in Java and...

I like the idea of splitting this PR, to land the const options, and work on the variable styling separately. If you have an idea of how to support multiple...

I like this idea, though I'm not a fan of the "= default" version of this which doesn't guarantee any initialization at all. I think it would be best to...

I think my comments #216 cover this. I like making it configurable, though I'd prefer making it per-record-type via "deriving" rather than a command-line option. However, I feel strongly that...

In most cases, I consider creating objects in non-initialized states to be a bug not a feature in the languages which have it. I can see the argument for it...

I'd be okay with default constructor as a separate option, either in deriving, or on the command-line. It's a bit cpp-specific. Would you create constructors with the same minimal behavior...

@syedhali you should be able to pull a specific old commit of gyp which still supports Android, which is what's done in the Djinni Makefile. Not a great solution, but...

I'll take the role of designated reviewer here. Sorry for my part of the multi-comment confusion. I'm new to the github workflow, and was disoriented by its inability to carry...

Yeah, I don't think you can easily get weak-ref semantics across languages in a portable way. If your C++ library kept a weak_ptr to the proxy object, it would work,...

Interesting idea. The actual loading of the class in Java is is something you could accomplish on your own if you write a custom JNI_OnLoad, or could handle from Java...