Andrew Twyman

Results 115 comments of Andrew Twyman

Thanks for your effort! This repo is no longer supported by Dropbox and about to be archived. I'm not going to try to merge this PR at the last minute,...

I don't know of anyone running asan on this repo before, no. It's cool to see that kind of rigor being applied. I'd be happy to take a look at...

That's not a PR it's a diff in your repo. You need to submit a PR and sign the Dropbox CLA before I could consider merging anything. https://opensource.dropbox.com/cla/ . That...

If you need fidelity for a full 64 bits, your best bet is to encode your IDs as strings rather than numbers. Or modify your own fork with something like...

Maintaining a separate branch would add some maintenance overhead, though admittedly less confusingly than multiple forks. It might be better to provide both options controlled by ifdefs, or as distinct...

@fosterbrereton That's an intentional limitation for compatibility, as described here: https://github.com/dropbox/json11/blob/710352234426a869b5ebd4f2e5ff8c71ccd6bc07/json11.hpp#L16-L22 It's not about the JSON spec (which doesn't say anything about numeric sizes) but about compatibility with all major...

Thanks for the PR, @danielschenk. I don't know anything about PlatformIO, so am not sure what opinion to have on this one. It's certainly non-dangerous, but I'm not sure about...

Thanks for your effort! This repo is no longer supported by Dropbox and about to be archived. Since CMAKE was community-submitted and not something I was set up to test,...

You might be able to minimize the internal impact without forcing the class itself to be a template, if you have a template method which takes something string-view-like. E.g. implement...

Hi @canatella. Trying to get caught up on PR's during the holiday lull. I'm not opposed to supporting event-based parsing in theory (though I wonder if @j4cbo has thoughts as...