OpenChord icon indicating copy to clipboard operation
OpenChord copied to clipboard

Create custom chords

Open artutra opened this issue 4 years ago • 3 comments

artutra avatar Jun 04 '20 22:06 artutra

As given here https://www.chordpro.org/chordpro/Directives-define.html one can define chord manually in the chordpro file. But I guess you thought about editing manually the chord svg by moving the dots?

One thing I do not have any idea how to solve is the transpose problem. Should it be transposed?

faniry6 avatar Jun 11 '20 12:06 faniry6

First, no, I believe that the custom chord should not be transposed. If the song is transposed it will show the chords from the database again until you customise the new transposed chord.

About SVG, I intend to create an UI for every metadata of the chordpro specification (such as capo, tunning, tempo, custom chord definition, etc) so, to create a custom chord specification you should:

  • add a new property to Song model with an array of custom chords
  • modify ChordTab component to look for a custom chord first and only after look at the chord database
  • create a new screen to any user be able to edit a chord with visual feedback

I am still creating a button to import .chordpro files on the Settings tab, but after I complete it, we should look for the best way to parse the chordpro text and extract the custom chords from it

artutra avatar Jun 12 '20 15:06 artutra

Having these features would be amazing 😁

faniry6 avatar Jun 13 '20 22:06 faniry6