arturo icon indicating copy to clipboard operation
arturo copied to clipboard

[VM/values/value] `cleanBlock` is too slow

Open github-actions[bot] opened this issue 1 year ago • 0 comments

[VM/values/value] cleanBlock is too slow

when built without NOERRORLINES - which is our normal setup - this specific piece of code could be slowing down the whole language by up to 20%

https://github.com/arturo-lang/arturo/blob/bc5bd6b2c8cb65042d1b80d140ce8d2c5431977a/src/vm/values/value.nim#L853

        return x.params.a.len

# TODO(VM/values/value) `cleanBlock` is too slow
#  when built without NOERRORLINES - which is our normal setup - this specific piece of code could be slowing down the whole language by up to 20%
#  labels: vm, values, performance, enhancement, benchmark, critical
template cleanBlock*(va: ValueArray, inplace: bool = false): untyped =
    when not defined(NOERRORLINES):
        when inplace:
ew file mode 100755
ndex 000000000..6b871481e
++ b/tools/benchmark.art

683e44ff95214bc935542c0792abe238fb88a8bf

github-actions[bot] avatar Aug 11 '22 12:08 github-actions[bot]