google-wallpaper-downloaders icon indicating copy to clipboard operation
google-wallpaper-downloaders copied to clipboard

Updated code to keep up with the latest version of extension (3.0.3).

Open kzvdar42 opened this issue 5 years ago • 7 comments

Updated the code & wallpapers IDs file to keep up with the changes in the API.

Also upped the python to 3.4, cause the python 2 is deprecated.

kzvdar42 avatar Feb 13 '20 08:02 kzvdar42

@cgiAlexis, I've seen you've been trying to update the code, so I hope this helps)

kzvdar42 avatar Feb 13 '20 08:02 kzvdar42

This is amazing just to read and see how you've implemented it, thank you!

cgiAlexis avatar Feb 13 '20 17:02 cgiAlexis

Thanks, @kzvdar42. Very nice PR.

I was comparing the (1) https://earthview.withgoogle.com/download/{}.jpg vs (2) https://www.gstatic.com/prettyearth/assets/full/{}.jpg and noticed this:

  • All images are visually the same, except for copyright at the bottom
  • Same resolution: 1800x1200
  • the filesize of (1) is sometimes higher than (2) because they're not optmized. Found this comment in some (2) files: Optimized by JPEGmini 3.11.4.3 0x37a6e51a
  • About 5477 ~and 5478~: (1) returns 404, (2) returns a valid wallpaper

4llan avatar Feb 20 '20 12:02 4llan

Missing ids

from https://earthview.withgoogle.com/_api/photos.json

from my old links:

4llan avatar Feb 20 '20 12:02 4llan

Where did you get these new ids?

Because I just pulled all ids from their official chrome extension code.

kzvdar42 avatar Feb 20 '20 12:02 kzvdar42

I've fetched https://earthview.withgoogle.com/_api/photos.json and sorted ids. I've updated my comment above. 5477 and 7014 are ids from my old notes.

4llan avatar Feb 20 '20 12:02 4llan

Thanks, @4llan! Your interest gave me the motivation to improve the code) I added the missing ids, removed all dependencies, added handling of the 404 pages and updated the README with yours observations.

kzvdar42 avatar Feb 20 '20 16:02 kzvdar42