Artur Bać

Results 60 comments of Artur Bać

@jbbjarnason are we going to merge it ? Is it ready to merge or You want to add anything ?

Will try soon take a look at repo impl, currently I am bit busy.

Did You solve it ? ``` /home/artur/projects/glaze/build/tests/json_test> /home/artur/projects/glaze/build/tests/json_test/json_test /home/artur/projects/glaze/include/glaze/util/dump.hpp:168:34: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:44:28: note: nonnull attribute specified here...

As You probably know this code is invalid. And it is difficult to understand. any uses storage to store in buffer value of dog * raw_ptr holds address to that...

I was wrong I need this fix, it just ignores my specialization of subset without fix ..

same for read fix, then everything works ``` template requires(std::is_enum_v && !glaze_enum_t && !meta::custom_read) struct from_json { ```

I am working on it, need to write a check it meta is specialized and is set to true, easy job

If You want to fix it then bunch of info as alone I will not solve issue with partial spec it requires more knowlegde on glaze. As I mentioned there...

An dbtw I had to consrtaint glaze_value_t too .. will do PR

Let me know if You need anything to examine related to enumerations, I can branch simple enum glaze support and test it and try to help