simpledb-webview icon indicating copy to clipboard operation
simpledb-webview copied to clipboard

The require.paths is no longer supported in the new version of node. So ...

Open doitdistributed opened this issue 13 years ago • 7 comments
trafficstars

...the custom packages should be moved to node_modules

doitdistributed avatar Dec 09 '11 16:12 doitdistributed

Hey, this is great. Do you mind completing the patch by removing the line (instead of commenting it out), and moving aws-lib to node_modules ?

I think this will require introducing an exception to .gitignore for node_modules/aws-lib.

Thanks!

arturadib avatar Dec 12 '11 14:12 arturadib

No problem I will make it. I was not absolutely sure if you wanted to migrate to the new version. But now I know :-)

doitdistributed avatar Dec 12 '11 15:12 doitdistributed

ok my forked version is now complete and on v0.6.5 https://github.com/doITdistributed/simpledb-webview

doitdistributed avatar Dec 15 '11 12:12 doitdistributed

So it seems like the pull requests #14 and #13 make it so that aws-lib is installed via npm. The problem is that there's a bug with aws-lib v0.5.0 which I fixed here:

https://github.com/arturadib/simpledb-webview/blob/master/custom_modules/aws-lib/lib/aws.js#L100

So if you use npm's default aws-lib, that will bring back the ! bug.

I think the solution is to find a way to use the bundled aws-lib without using require.paths.

arturadib avatar Jan 03 '12 15:01 arturadib

Shouldn't we submit the fix to the aws-lib then?

doitdistributed avatar Jan 07 '12 15:01 doitdistributed

Shouldn't we submit the fix to the aws-lib then?

It has been fixed but apparently never updated on npm:

https://github.com/livelycode/aws-lib/blob/master/lib/aws.js#L101

arturadib avatar Jan 09 '12 19:01 arturadib

hmpf :-)

doitdistributed avatar Jan 10 '12 12:01 doitdistributed