helmify icon indicating copy to clipboard operation
helmify copied to clipboard

Add HorizontalPodAutoScaler Processor

Open DheerajKN opened this issue 5 months ago • 7 comments

Adding support for HorizontalPodAutoScaler from autoscaling/v1 primarily targeting minReplicas maxReplicas and targetCPUUtilizationPercentage

DheerajKN avatar Aug 06 '25 17:08 DheerajKN

@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error

DheerajKN avatar Aug 07 '25 15:08 DheerajKN

@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error

It looks strange. I can see in PR diff also new service template and PDB.

arttor avatar Aug 07 '25 15:08 arttor

@arttor The CI process is failing, can you help me explain what the issue is. Cant understand the error

It looks strange. I can see in PR diff also new service template and PDB.

Yeah exactly that;s the reason why I ignored those changes and only committed mine. Think some devs are evening updating examples

DheerajKN avatar Aug 07 '25 15:08 DheerajKN

it can be related common prefix in resource name. can you try to rename it from myapp-pdb to my-pdb or pdb

arttor avatar Aug 07 '25 15:08 arttor

it can be related common prefix in resource name. can you try to rename it from myapp-pdb to my-pdb or pdb

sorry, i was speaking about your example, not pdb. existing examples should remain the same. myapp-hpa -> my-hpa

in example diff we should see only hpa template and its value in values.yaml.

arttor avatar Aug 07 '25 16:08 arttor

@arttor Checks are all passing, can you review and merge this PR?

DheerajKN avatar Aug 07 '25 20:08 DheerajKN

@arttor Checks are all passing, can you review and merge this PR?

sorry, we need to check why all existing templates were renamed. probably there is a bug in exiting code but i cannot merge this change. If we add only one hpa to test samples we should get only one template in result and no changes to other templates.

arttor avatar Aug 08 '25 06:08 arttor