helmify icon indicating copy to clipboard operation
helmify copied to clipboard

Published 20 hours ago • verified publisher icon arttor

add support for optional secrets using flag optional-secrets

Open manherna opened this issue 1 year ago • 4 comments

Add support for optional secrets which are not required by default.

related to https://github.com/arttor/helmify/issues/152

manherna avatar Nov 21 '24 15:11 manherna

Hi @arttor! It took me a while, but I found time to push this PR. What do you think? Does it suit the project scope? Does it lack anything?

manherna avatar Nov 25 '24 07:11 manherna

Hi @arttor what do you think? Can this be merged?

manherna avatar Jan 09 '25 09:01 manherna

sorry for not responding. But i am a bit struggling to understand the feature by looking at the code. Can you please explain what it does and what is the use-case?

arttor avatar Feb 08 '25 19:02 arttor

Hi @arttor sorry, this went over my head. The aim of this MR is to be able to decide wether a specific secret in the kustomize manifests is optional. An optional secret, as per my view, is one that will be only created if its value is passed during installation and it is not null.

Imagine a registryCredentials secret. With this approach, the user installing the chart could decide to either install the chart with the value .Values.regisgtryCredentials.token and then the secret myhelmchart-registrycredentials would be created. If, on the other hand, they would decide to leave that value empty or not define it, the secret myhelmchart-registrycredentials would not be created.

In my opinion this is useful because it allows users to either have the comfort of having a secret created upon install, or if they want they can define the secret themselves and maybe use something like ExternalSecrets to manage it.

manherna avatar May 29 '25 08:05 manherna