helmify icon indicating copy to clipboard operation
helmify copied to clipboard

Chart.Appversion not as a default usable since image.tag set in values.yaml

Open batistein opened this issue 4 years ago • 3 comments

Thank you for this amazing project.

When generating the charts, the image tag is also set in values.yaml. In the deployment itself, the default is set correctly (.Chart.Appversion) , but it can not be used by default since the image tag is set in the values.yaml. Especially with the combination of helmify with helmfile where values are only overwritten this is a little bit disturbing.

batistein avatar Dec 02 '21 21:12 batistein

Thank you for the feedback!

Totally agree that Appversion should be a default value for the image tag of the main container. But it is difficult to identify the main container if there are several sidecars in a pod.

I was thinking that people will use helmify to generate boilerplate and will do some polishing afterward. In this case, it is better to have all stuff in values.yaml, and users will remove redundant params.

I can see several options:

  • always remove image tag from values.yaml
  • remove image tag from values.yaml if pod has 1 container
  • remove image tag from values.yaml if it has "latest" value
  • remove image tag from values.yaml if its value equals to Appversion

What do you think?

arttor avatar Dec 04 '21 10:12 arttor

Hello @arttor, I running into the same issue. We need to remove the tag from image, but there is no option to do that.

I prefer to the option always remove image tag from values.yaml, but we can avoid BC with --no-image-tag in the CLI

giautm avatar Aug 23 '23 01:08 giautm