helmify
helmify copied to clipboard
Fix pdb
minAvailable and maxUnavailable are mutually exclusive, this fix handles that requirement,
helmify does not validate input k8s manifests. It tries to convert any input to Helm template with the best effort. I am not sure that we should do exception for pdb here.
I'm fine with not doing any validation and instead just passing through what helmify gets. The fix here is mostly around correcting the template error
https://github.com/arttor/helmify/pull/136/commits/07b07199f15725968a17a33c39ebda1f95174a5c#diff-8760a54892606e12340f2e99b239fe386b23663d702e89ef26b0e0ec761942a4L23-L24
This is invalid from the start, so helmify is introducing invalid manifests by always passing minAvailable and maxUnavailable via the way the template is constructed.
I propose just removing the error logging so validation is not a concern, then include the template fix that ensures helmify does not make all PDB manifests it encounters invalid.
oh, i see the problem now. thanks!