helmify icon indicating copy to clipboard operation
helmify copied to clipboard

feat: templatize values

Open vbehar opened this issue 2 years ago • 1 comments

instead of using raw values - such as {{ .Values.some.thing }} - let's wrap them with the tpl function.

the previous example would then be rendered as {{ tpl (.Values.some.thing) $ }}

So that we can reference other values from inside our values for example.

vbehar avatar May 17 '23 11:05 vbehar

Hi @vbehar! Thank you for your contribution. The proposal looks very interesting but i see several potential problems:

  • the change is quite big and it is better to hide it under a feature flag to not surprise users after upgrading to a new version
  • overusing tpl function may lead to performance issues see
  • in the PR, not all template values are wrapped into tpl. How to decide which one should be wrapped?

arttor avatar May 27 '23 10:05 arttor