artsy
[Messaging] conversation.last_message should be nullable
I'm gonna close this since it seems like it was b/c of some simultaneous data migrations around encryption happening.
We'll make new inquiries and can re-open or create new schema issues as needed (from a cleaner slate of fresh inquiries).
Yup I've been noticing this- in the few seconds or so after placing an inquiry, I guess we can retrieve the conversation but last_message is null for a bit.
Does it make sense for us to be able to retrieve the conversation while last_message is still null? Like, can we show anything yet? If not, maybe MP should return null for the conversation while last_message is still null?
Looking at the code in Impulse/Radiation a bit more closely, it looks like the Conversation is created in Impulse -> Messages created in Radiation -> Webhook back to create messages in Impulse.
So, we have a whole other step in between the time that a conversation is available in Impulse, and when last_message is available in Impulse.
Does it make sense for us to be able to retrieve the conversation while last_message is still null? Like, can we show anything yet? If not, maybe MP should return null for the conversation while last_message is still null?
Yea I think that's right. If last_message is null that means you just initiated the inquiry (and there isn't even any proper messages 'yet') so we should probably just skip those conversations altogether.