metaphysics icon indicating copy to clipboard operation
metaphysics copied to clipboard

Published 20 hours ago • verified publisher icon artsy

chore: sort query params when generating a Gemini CDN URL

Open mzikherman opened this issue 2 years ago • 1 comments

Might as well do this!

mzikherman avatar Oct 06 '22 21:10 mzikherman

Warnings
:warning: The V2 schema in this PR has breaking changes with Force. Remember to update the Force schema if necessary.

Type 'partnerArtistsSearchConnection' was removed Type 'partnerArtistsSearchEdge' was removed Type 'partnerArtworksSearchConnection' was removed Type 'partnerArtworksSearchEdge' was removed Type 'partnerShowsSearchConnection' was removed Type 'partnerShowsSearchEdge' was removed Field 'partnerArtistsSearchConnection' was removed from object type 'Partner' Field 'partnerArtworksSearchConnection' was removed from object type 'Partner' Field 'partnerShowsSearchConnection' was removed from object type 'Partner'

Generated by :no_entry_sign: dangerJS against 4dfef8d455eb6ccc6ce369ded145911a9b238d7f

artsy-peril[bot] avatar Oct 06 '22 21:10 artsy-peril[bot]

Just noticed this old thing, which still seems like a good idea. The test failure looks like a legit+easy fix.

joeyAghion avatar Oct 26 '22 19:10 joeyAghion

Ping @mzikherman!

joeyAghion avatar Nov 29 '22 15:11 joeyAghion

Updated (plus removed the code supporting the serverless CDN experiment).

mzikherman avatar Nov 29 '22 17:11 mzikherman