metaphysics icon indicating copy to clipboard operation
metaphysics copied to clipboard

WIP - evaluate schema drift

Open jonallured opened this issue 3 years ago • 4 comments

I noticed some drift in the schema that vortex has checked into its repo vs the one that exists in MP so I asked about it here:

https://artsy.slack.com/archives/CP9P4KR35/p1644856104672509

I came to understand that the drift was not intentional and my assumptions were shared by other engineers: that the schema in vortex should match the schema in MP for that service. So that got me wondering if other services had drift. What this PR does is loop through the stitched services and copy their schema files over to MP and then I ran yarn dump:local and committed all the resulting diff - it's a lot!

What should we do about this? @damassi @ansor4 @joeyAghion @dzucconi @anandaroop @bhoggard @sweir27

jonallured avatar Feb 15 '22 16:02 jonallured

Warnings
:warning:

The V2 schema in this PR has breaking changes with Force. Remember to update the Force schema if necessary.

Type 'ArtistSeriesConnection' was removed Type 'ArtistSeriesEdge' was removed Type 'ArtistSeries' was removed Type 'AnalyticsPartnerStats' was removed Type 'AnalyticsQueryPeriodEnum' was removed Type 'AnalyticsPartnerStatsArtworksPublished' was removed Type 'AnalyticsPartnerStatsArtworksPublishedTimeSeries' was removed Type 'AnalyticsDateTime' was removed Type 'AnalyticsArtworksPublishedStats' was removed Type 'AnalyticsPartnerTimeSeriesStats' was removed Type 'AnalyticsPartnerAudienceStats' was removed Type 'AnalyticsGroupedStatsMetricEnum' was removed Type 'AnalyticsGroupedStatsObjectTypeEnum' was removed Type 'AnalyticsGroupedStatsConnection' was removed Type 'AnalyticsGroupedStatsEdge' was removed Type 'AnalyticsGroupedStats' was removed Type 'AnalyticsGroupedStatsUnion' was removed Type 'AnalyticsVisitorsByCountry' was removed Type 'AnalyticsVisitorsByDevice' was removed Type 'AnalyticsVisitorsByLandingPage' was removed Type 'AnalyticsVisitorsByReferral' was removed Type 'AnalyticsPageInfo' was removed Type 'AnalyticsPartnerInquiryStats' was removed Type 'AnalyticsPartnerInquiryCountTimeSeriesStats' was removed Type 'AnalyticsPartnerStatsPageviews' was removed Type 'AnalyticsPartnerStatsPageviewsTimeSeries' was removed Type 'AnalyticsPageviewStats' was removed Type 'AnalyticsRankedStatsObjectTypeEnum' was removed Type 'AnalyticsRankedStatsConnection' was removed Type 'AnalyticsRankedStatsEdge' was removed Type 'AnalyticsRankedStats' was removed Type 'AnalyticsRankedEntityUnion' was removed Type 'MarketingCollection' was removed Type 'MarketingDateTime' was removed Type 'MarketingCollectionGroup' was removed Type 'MarketingGroupTypes' was removed Type 'MarketingCollectionQuery' was removed Type 'ViewingRoomsConnection' was removed Type 'ViewingRoomsEdge' was removed Type 'ViewingRoom' was removed Type 'ISO8601DateTime' was removed Type 'ARImage' was removed Type 'ImageURLs' was removed Type 'ViewingRoomSubsection' was removed Type 'ViewingRoomArtwork' was removed Type 'AnalyticsRankedStatsUnion' was removed Type 'AnalyticsArtist' was removed Type 'AnalyticsArtwork' was removed Type 'AnalyticsShow' was removed Type 'AnalyticsViewingRoom' was removed Type 'AnalyticsPartnerSalesStats' was removed Type 'AnalyticsPartnerSalesTimeSeriesStats' was removed Type 'ViewingRoomStatusEnum' was removed Type 'AnalyticsUserStats' was removed Type 'Device' was removed Type 'AnalyticsPricingContext' was removed Type 'AnalyticsPriceContextFilterType' was removed Type 'AnalyticsPricingContextCategoryEnum' was removed Type 'AnalyticsPricingContextDimensionEnum' was removed Type 'AnalyticsHistogramBin' was removed Type 'CommerceOrderParticipantEnum' was removed Type 'CommerceOrderStateEnum' was removed Type 'CommerceOrderConnectionWithTotalCount' was removed Type 'CommerceOrderEdge' was removed Type 'CommerceOrder' was removed Type 'CommerceOrderPartyUnion' was removed Type 'CommercePartner' was removed Type 'CommerceUser' was removed Type 'CommerceOrderDisplayStateEnum' was removed Type 'CommerceLineItemConnection' was removed Type 'CommerceLineItemEdge' was removed Type 'CommerceLineItem' was removed Type 'CommerceFulfillmentConnection' was removed Type 'CommerceFulfillmentEdge' was removed Type 'CommerceFulfillment' was removed Type 'CommercePageInfo' was removed Type 'CommerceShippingQuote' was removed Type 'CommerceShipment' was removed Type 'CommerceShippingQuoteConnection' was removed Type 'CommerceShippingQuoteEdge' was removed Type 'CommerceOrderModeEnum' was removed Type 'CommerceOrderEventUnion' was removed Type 'CommerceOfferSubmittedEvent' was removed Type 'CommerceEventInterface' was removed Type 'CommerceOffer' was removed Type 'CommerceOrderStateChangedEvent' was removed Type 'CommerceRequestedFulfillmentUnion' was removed Type 'CommercePickup' was removed Type 'CommerceShip' was removed Type 'CommerceShipArta' was removed Type 'CommerceOrderSourceEnum' was removed Type 'CommercePageCursors' was removed Type 'CommercePageCursor' was removed Type 'AuctionsLotState' was removed Type 'Long' was removed Type 'AuctionsBidder' was removed Type 'AuctionsArtsyBidder' was removed Type 'AuctionsOfflineBidder' was removed Type 'AuctionsReserveStatus' was removed Type 'AuctionsSoldStatus' was removed Type 'AuctionsLotStandingConnection' was removed Type 'AuctionsLotStandingEdge' was removed Type 'AuctionsLotStanding' was removed Type 'AuctionsNode' was removed Type 'AuctionsMoney' was removed Type 'AuctionsPageInfo' was removed Type 'Algolia' was removed Type 'AlgoliaIndex' was removed Type 'DoNotUseThisPartner' was removed Type 'SearchCriteriaAttributes' was removed Type 'SearchCriteria' was removed Type 'SavedSearchUserAlertSettings' was removed Type 'SearchCriteriaConnection' was removed Type 'SearchCriteriaEdge' was removed Type 'SecondFactorKind' was removed Type 'SecondFactor' was removed Type 'UserAddressConnection' was removed Type 'UserAddressEdge' was removed Type 'UserAddress' was removed Type 'Agreement' was removed Type 'AuctionResultsByArtistsConnection' was removed Type 'AuctionResultsByArtistsEdge' was removed Type 'AuctionResultsByArtists' was removed Type 'BigInt' was removed Type 'CommerceOrderConnectionSortEnum' was removed Type 'ConsignmentSort' was removed Type 'ConsignmentConnection' was removed Type 'ConsignmentEdge' was removed Type 'Consignment' was removed Type 'ConsignmentState' was removed Type 'ConsignmentSubmission' was removed Type 'ConsignmentSubmissionCategoryAsset' was removed Type 'ConsignmentAttributionClass' was removed Type 'ConsignmentOffer' was removed Type 'ConsignmentSubmissionStateAggregation' was removed Type 'ConsignmentPageCursors' was removed Type 'ConsignmentPageCursor' was removed Type 'HomePageMarketingCollectionsModule' was removed Type 'MarketingCollectionCategory' was removed Type 'MarketPriceInsights' was removed Type 'ConsignmentOfferSort' was removed Type 'ConsignmentOfferConnection' was removed Type 'ConsignmentOfferEdge' was removed Type 'PriceInsightSort' was removed Type 'PriceInsightConnection' was removed Type 'PriceInsightEdge' was removed Type 'ConsignmentSubmissionCategoryAggregation' was removed Type 'ConsignmentSubmissionSort' was removed Type 'ConsignmentSubmissionConnection' was removed Type 'SubmissionEdge' was removed Type 'ViewingRoomConnection' was removed Type 'ViewingRoomEdge' was removed Type 'AcceptPartnerAgreementInput' was removed Type 'AcceptPartnerAgreementPayload' was removed Type 'PartnerAgreementOrErrorsUnion' was removed Type 'Errors' was removed Type 'Error' was removed Type 'PartnerAgreement' was removed Type 'AddAssetsToConsignmentSubmissionInput' was removed Type 'AddAssetsToConsignmentSubmissionPayload' was removed Type 'AddAssetToConsignmentSubmissionInput' was removed Type 'AddAssetToConsignmentSubmissionPayload' was removed Type 'CaptureHoldInput' was removed Type 'CaptureHoldPayload' was removed Type 'InventoryHoldOrErrorUnion' was removed Type 'InventoryHold' was removed Type 'InventoryHoldItemConnection' was removed Type 'InventoryHoldItemEdge' was removed Type 'InventoryHoldItem' was removed Type 'CommerceAddInitialOfferToOrderInput' was removed Type 'CommerceAddInitialOfferToOrderPayload' was removed Type 'CommerceOrderOrFailureUnion' was removed Type 'CommerceOrderRequiresAction' was removed Type 'CommerceOrderActionData' was removed Type 'CommerceOrderWithMutationFailure' was removed Type 'CommerceApplicationError' was removed Type 'CommerceOrderWithMutationSuccess' was removed Type 'CommerceApproveOrderInput' was removed Type 'CommerceShippingContactAttributes' was removed Type 'CommerceApproveOrderPayload' was removed Type 'CommerceBuyerAcceptOfferInput' was removed Type 'CommerceBuyerAcceptOfferPayload' was removed Type 'CommerceBuyerCounterOfferInput' was removed Type 'CommerceBuyerCounterOfferPayload' was removed Type 'CommerceBuyerRejectOfferInput' was removed Type 'CommerceCancelReasonTypeEnum' was removed Type 'CommerceBuyerRejectOfferPayload' was removed Type 'CommerceConfirmFulfillmentInput' was removed Type 'CommerceConfirmFulfillmentPayload' was removed Type 'CommerceConfirmPickupInput' was removed Type 'CommerceConfirmPickupPayload' was removed Type 'CommerceCreateInquiryOfferOrderWithArtworkInput' was removed Type 'CommerceCreateInquiryOfferOrderWithArtworkPayload' was removed Type 'CommerceCreateOfferOrderWithArtworkInput' was removed Type 'CommerceCreateOfferOrderWithArtworkPayload' was removed Type 'CommerceCreateOrderWithArtworkInput' was removed Type 'CommerceCreateOrderWithArtworkPayload' was removed Type 'CommerceFixFailedPaymentInput' was removed Type 'CommerceFixFailedPaymentPayload' was removed Type 'CommerceFulfillAtOnceInput' was removed Type 'CommerceFulfillmentAttributes' was removed Type 'CommerceDate' was removed Type 'CommerceFulfillAtOncePayload' was removed Type 'CommerceRejectOrderInput' was removed Type 'CommerceRejectOrderPayload' was removed Type 'CommerceSelectShippingOptionInput' was removed Type 'CommerceSelectShippingOptionPayload' was removed Type 'CommerceSellerAcceptOfferInput' was removed Type 'CommerceSellerAcceptOfferPayload' was removed Type 'CommerceSellerAcceptProvisionalOfferInput' was removed Type 'CommerceSellerAcceptProvisionalOfferPayload' was removed Type 'CommerceSellerCounterOfferInput' was removed Type 'CommerceSellerCounterOfferPayload' was removed Type 'CommerceSellerRejectOfferInput' was removed Type 'CommerceSellerRejectOfferPayload' was removed Type 'CommerceSetPaymentInput' was removed Type 'CommerceSetPaymentPayload' was removed Type 'CommerceSetShippingInput' was removed Type 'CommerceOrderFulfillmentTypeEnum' was removed Type 'CommerceShippingAttributes' was removed Type 'CommerceSetShippingPayload' was removed Type 'CommerceSubmitOrderInput' was removed Type 'CommerceSubmitOrderPayload' was removed Type 'CommerceSubmitOrderWithOfferInput' was removed Type 'CommerceSubmitOrderWithOfferPayload' was removed Type 'CommerceSubmitPendingOfferInput' was removed Type 'CommerceSubmitPendingOfferPayload' was removed Type 'ConfirmPasswordInput' was removed Type 'ConfirmPasswordPayload' was removed Type 'CreateAppSecondFactorInput' was removed Type 'AppSecondFactorAttributes' was removed Type 'CreateAppSecondFactorPayload' was removed Type 'AppSecondFactorOrErrorsUnion' was removed Type 'AppSecondFactor' was removed Type 'CreateBackupSecondFactorsInput' was removed Type 'CreateBackupSecondFactorsPayload' was removed Type 'BackupSecondFactorsOrErrorsUnion' was removed Type 'BackupSecondFactors' was removed Type 'BackupSecondFactor' was removed Type 'CreateOfferMutationInput' was removed Type 'Date' was removed Type 'CreateOfferMutationPayload' was removed Type 'CreateOfferResponseMutationInput' was removed Type 'IntendedState' was removed Type 'CreateOfferResponseMutationPayload' was removed Type 'OfferResponse' was removed Type 'CreateSubmissionMutationInput' was removed Type 'CreateSubmissionMutationPayload' was removed Type 'CreateImageInput' was removed Type 'CreateImagePayload' was removed Type 'CreateSavedSearchInput' was removed Type 'UserAlertSettingsInput' was removed Type 'CreateSavedSearchPayload' was removed Type 'SearchCriteriaOrErrorsUnion' was removed Type 'CreateSmsSecondFactorInput' was removed Type 'SmsSecondFactorAttributes' was removed Type 'CreateSmsSecondFactorPayload' was removed Type 'SmsSecondFactorOrErrorsUnion' was removed Type 'SmsSecondFactor' was removed Type 'CreateUserAddressInput' was removed Type 'UserAddressAttributes' was removed Type 'CreateUserAddressPayload' was removed Type 'UserAddressOrErrorsUnion' was removed Type 'CreateViewingRoomInput' was removed Type 'ViewingRoomAttributes' was removed Type 'ARImageInput' was removed Type 'CreateViewingRoomPayload' was removed Type 'ViewingRoomOrErrorsUnion' was removed Type 'DeleteUserAddressInput' was removed Type 'DeleteUserAddressPayload' was removed Type 'DeleteViewingRoomInput' was removed Type 'DeleteViewingRoomPayload' was removed Type 'DeliverSecondFactorInput' was removed Type 'DeliverSecondFactorPayload' was removed Type 'SecondFactorOrErrorsUnion' was removed Type 'DisableSavedSearchInput' was removed Type 'DisableSavedSearchPayload' was removed Type 'DisableSecondFactorInput' was removed Type 'DisableSecondFactorPayload' was removed Type 'EnableSecondFactorInput' was removed Type 'EnableSecondFactorPayload' was removed Type 'HoldInventoryInput' was removed Type 'InventoryHoldItemAttributes' was removed Type 'HoldInventoryPayload' was removed Type 'InventoryHoldOrErrorsUnion' was removed Type 'PublishViewingRoomInput' was removed Type 'PublishViewingRoomPayload' was removed Type 'RecordArtworkViewInput' was removed Type 'RecordArtworkViewPayload' was removed Type 'RemoveAssetFromConsignmentSubmissionInput' was removed Type 'RemoveAssetFromConsignmentSubmissionPayload' was removed Type 'RequestConditionReportInput' was removed Type 'RequestConditionReportPayload' was removed Type 'ConditionReportRequest' was removed Type 'UnpublishViewingRoomInput' was removed Type 'UnpublishViewingRoomPayload' was removed Type 'UpdateAppSecondFactorInput' was removed Type 'UpdateAppSecondFactorPayload' was removed Type 'UpdateSubmissionMutationInput' was removed Type 'UpdateSubmissionMutationPayload' was removed Type 'UpdateSavedSearchInput' was removed Type 'UpdateSavedSearchPayload' was removed Type 'UpdateSmsSecondFactorInput' was removed Type 'UpdateSmsSecondFactorPayload' was removed Type 'UpdateUserAddressInput' was removed Type 'UpdateUserAddressPayload' was removed Type 'UpdateUserDefaultAddressInput' was removed Type 'UpdateUserDefaultAddressPayload' was removed Type 'UpdateViewingRoomInput' was removed Type 'UpdateViewingRoomPayload' was removed Type 'UpdateViewingRoomArtworksInput' was removed Type 'ViewingRoomArtworkInput' was removed Type 'UpdateViewingRoomArtworksPayload' was removed Type 'UpdateViewingRoomSubsectionsInput' was removed Type 'ViewingRoomSubsectionInput' was removed Type 'ViewingRoomSubsectionAttributes' was removed Type 'UpdateViewingRoomSubsectionsPayload' was removed Type 'AuctionsDateTime' was removed Type 'AuctionsIncrementPolicy' was removed Type 'AuctionsIncrementPolicyChange' was removed Type 'AuctionsNextIncrementRule' was removed Type 'AuctionsIncrementPolicyChangeInput' was removed Type 'AuctionsIncrementPolicyGroup' was removed Type 'AuctionsIncrementPolicySubgroup' was removed Type 'AuctionsNewIncrementPolicy' was removed Type 'AuctionsNewIncrementPolicyInput' was removed Type 'AuctionsSaleState' was removed Type 'AuctionsUser' was removed Type 'CommerceBuyerOfferActionEnum' was removed Type 'CommerceBuyOrder' was removed Type 'CommerceDateTime' was removed Type 'CommerceOfferConnection' was removed Type 'CommerceOfferEdge' was removed Type 'CommerceOfferOrder' was removed Type 'MoneyOrErrorUnion' was removed Type 'PartnerLocation' was removed Type 'SaleAdministrationFields' was removed Field '_unused_auctionsLot' was removed from object type 'Query' Field '_unused_auctionsLotStandingConnection' was removed from object type 'Query' Field '_unused_gravity_algolia' was removed from object type 'Query' Field '_unused_gravity_devices' was removed from object type 'Query' Field '_unused_gravity_marketingCollection' was removed from object type 'Query' Field '_unused_gravity_match_partners' (deprecated) was removed from object type 'Query' Field '_unused_gravity_matchPartners' was removed from object type 'Query' Field '_unused_gravity_partner' was removed from object type 'Query' Field '_unused_gravity_partners' was removed from object type 'Query' Field '_unused_gravity_savedSearch' was removed from object type 'Query' Field '_unused_gravity_savedSearchesConnection' was removed from object type 'Query' Field '_unused_gravity_secondFactors' was removed from object type 'Query' Field '_unused_gravity_userAddressConnection' was removed from object type 'Query' Field '_unused_gravity_viewingRoomsConnection' was removed from object type 'Query' Field 'agreement' was removed from object type 'Query' Field 'analyticsLastUpdatedAt' was removed from object type 'Query' Field 'analyticsPartnerStats' was removed from object type 'Query' Field 'analyticsUserStats' was removed from object type 'Query' Field 'artistSeries' was removed from object type 'Query' Field 'artistSeriesConnection' was removed from object type 'Query' Field 'auctionResultsByArtistsConnection' was removed from object type 'Query' Field 'commerceCompetingOrders' was removed from object type 'Query' Field 'commerceLineItems' was removed from object type 'Query' Field 'commerceMyOrders' was removed from object type 'Query' Field 'commerceOrder' was removed from object type 'Query' Field 'commerceOrders' was removed from object type 'Query' Field 'consignments' was removed from object type 'Query' Field 'marketingCategories' was removed from object type 'Query' Field 'marketingCollection' was removed from object type 'Query' Field 'marketingCollections' was removed from object type 'Query' Field 'marketingHubCollections' was removed from object type 'Query' Field 'marketPriceInsights' was removed from object type 'Query' Field 'offer' was removed from object type 'Query' Field 'offers' was removed from object type 'Query' Field 'priceInsights' was removed from object type 'Query' Field 'submission' was removed from object type 'Query' Field 'submissions' was removed from object type 'Query' Field 'viewingRoom' was removed from object type 'Query' Field 'viewingRooms' (deprecated) was removed from object type 'Query' Field 'orderConnection' was removed from object type 'Conversation' Field 'artistSeriesConnection' was removed from object type 'Artwork' Field 'pricingContext' was removed from object type 'Artwork' Field 'artistSeriesConnection' was removed from object type 'Artist' Field 'marketingCollections' was removed from object type 'Artist' Field 'analytics' was removed from object type 'Partner' Field 'viewingRoomsConnection' was removed from object type 'Partner' Field 'viewingRoomsConnection' was removed from object type 'Show' Field 'marketingCollections' was removed from object type 'Fair' Field 'analytics' was removed from object type 'User' Field 'devices' was removed from object type 'User' Field 'marketingCollectionsModule' was removed from object type 'HomePage' Field 'addressConnection' was removed from object type 'Me' Field 'auctionsLotStandingConnection' was removed from object type 'Me' Field 'orders' was removed from object type 'Me' Field 'savedSearch' was removed from object type 'Me' Field 'savedSearchesConnection' was removed from object type 'Me' Field 'secondFactors' was removed from object type 'Me' Field 'lot' was removed from object type 'Lot' Field 'algolia' was removed from object type 'System' Field 'marketingCollections' was removed from object type 'Viewer' Field 'viewingRoomsConnection' was removed from object type 'Viewer' Field 'acceptPartnerAgreement' was removed from object type 'Mutation' Field 'addAssetsToConsignmentSubmission' was removed from object type 'Mutation' Field 'addAssetToConsignmentSubmission' was removed from object type 'Mutation' Field 'captureHold' was removed from object type 'Mutation' Field 'commerceAddInitialOfferToOrder' was removed from object type 'Mutation' Field 'commerceApproveOrder' was removed from object type 'Mutation' Field 'commerceBuyerAcceptOffer' was removed from object type 'Mutation' Field 'commerceBuyerCounterOffer' was removed from object type 'Mutation' Field 'commerceBuyerRejectOffer' was removed from object type 'Mutation' Field 'commerceConfirmFulfillment' was removed from object type 'Mutation' Field 'commerceConfirmPickup' was removed from object type 'Mutation' Field 'commerceCreateInquiryOfferOrderWithArtwork' was removed from object type 'Mutation' Field 'commerceCreateOfferOrderWithArtwork' was removed from object type 'Mutation' Field 'commerceCreateOrderWithArtwork' was removed from object type 'Mutation' Field 'commerceFixFailedPayment' was removed from object type 'Mutation' Field 'commerceFulfillAtOnce' was removed from object type 'Mutation' Field 'commerceRejectOrder' was removed from object type 'Mutation' Field 'commerceSelectShippingOption' was removed from object type 'Mutation' Field 'commerceSellerAcceptOffer' was removed from object type 'Mutation' Field 'commerceSellerAcceptProvisionalOffer' was removed from object type 'Mutation' Field 'commerceSellerCounterOffer' was removed from object type 'Mutation' Field 'commerceSellerRejectOffer' was removed from object type 'Mutation' Field 'commerceSetPayment' was removed from object type 'Mutation' Field 'commerceSetShipping' was removed from object type 'Mutation' Field 'commerceSubmitOrder' was removed from object type 'Mutation' Field 'commerceSubmitOrderWithOffer' was removed from object type 'Mutation' Field 'commerceSubmitPendingOffer' was removed from object type 'Mutation' Field 'confirmPassword' was removed from object type 'Mutation' Field 'createAppSecondFactor' was removed from object type 'Mutation' Field 'createBackupSecondFactors' was removed from object type 'Mutation' Field 'createConsignmentOffer' was removed from object type 'Mutation' Field 'createConsignmentOfferResponse' was removed from object type 'Mutation' Field 'createConsignmentSubmission' was removed from object type 'Mutation' Field 'createImage' was removed from object type 'Mutation' Field 'createInquiryOfferOrder' was removed from object type 'Mutation' Field 'createSavedSearch' was removed from object type 'Mutation' Field 'createSmsSecondFactor' was removed from object type 'Mutation' Field 'createUserAddress' was removed from object type 'Mutation' Field 'createViewingRoom' was removed from object type 'Mutation' Field 'deleteUserAddress' was removed from object type 'Mutation' Field 'deleteViewingRoom' was removed from object type 'Mutation' Field 'deliverSecondFactor' was removed from object type 'Mutation' Field 'disableSavedSearch' was removed from object type 'Mutation' Field 'disableSecondFactor' was removed from object type 'Mutation' Field 'enableSecondFactor' was removed from object type 'Mutation' Field 'holdInventory' was removed from object type 'Mutation' Field 'publishViewingRoom' was removed from object type 'Mutation' Field 'recordArtworkView' was removed from object type 'Mutation' Field 'removeAssetFromConsignmentSubmission' was removed from object type 'Mutation' Field 'requestConditionReport' was removed from object type 'Mutation' Field 'submitOfferOrderWithConversation' was removed from object type 'Mutation' Field 'unpublishViewingRoom' was removed from object type 'Mutation' Field 'updateAppSecondFactor' was removed from object type 'Mutation' Field 'updateConsignmentSubmission' was removed from object type 'Mutation' Field 'updateSavedSearch' was removed from object type 'Mutation' Field 'updateSmsSecondFactor' was removed from object type 'Mutation' Field 'updateUserAddress' was removed from object type 'Mutation' Field 'updateUserDefaultAddress' was removed from object type 'Mutation' Field 'updateViewingRoom' was removed from object type 'Mutation' Field 'updateViewingRoomArtworks' was removed from object type 'Mutation' Field 'updateViewingRoomSubsections' was removed from object type 'Mutation'

Generated by :no_entry_sign: dangerJS against bd00bbfded4f5a0beeaa26179d34a6af0131d96d

artsy-peril[bot] avatar Feb 15 '22 16:02 artsy-peril[bot]

We use this to push MP changes to a number of different repos; perhaps we can go the other way and use it to push stitched schemas to MP, or spin up an intermediary service that will collect these schemas and push on a schedule.

damassi avatar Feb 15 '22 18:02 damassi

I guess my question is: was it a problem that Vortex's schema was out of date? Should it even be checked into version control (if it's not used locally, but only over in MP)?

Gravity deliberately removed that file from version control a while back (https://github.com/artsy/gravity/pull/13283)

OTOH if we are talking about automating the push from the upstream repos down to MP, then never mind, could be an interesting thing to pursue 👍🏽

anandaroop avatar Feb 15 '22 21:02 anandaroop

was it a problem that Vortex's schema was out of date?

The event that lead me down this trail was discovering that Vortex had a root query I wanted to use in MP but that it wasn't there. When I looked for code that might have been erasing it from the schema I did not find it. That lead to this Slack thread:

https://artsy.slack.com/archives/CP9P4KR35/p1644856104672509

Which eventually helped me see that the drift wasn't exactly intentional but in any case as the next engineer that wants to make a schema change that affects both Vortex and MP I'm in an awkward position. What seems to be ideal is that the schema for Vortex inside MP match exactly the schema inside Vortex. If we want to massage that schema to ultimately expose something different from MP that's fine but then that should be accounted for in MP.

Do other people have thoughts about this? Yesterday was literally the first day this topic occurred to me so I'm interested in hearing from others!

jonallured avatar Feb 15 '22 21:02 jonallured

Closing this old PR. 👍

jonallured avatar Nov 03 '22 15:11 jonallured