metaphysics icon indicating copy to clipboard operation
metaphysics copied to clipboard

Add some more possibilities for testing

Open pvinis opened this issue 3 years ago • 2 comments

We should use the full introspection to get all fields and inputFields and be able to check what is included.

For context: We added https://github.com/artsy/metaphysics/pull/2534 which is just a viewer with the root viewingRooms as viewingRoomsConnection. Then we added https://github.com/artsy/metaphysics/pull/2591 to have an inputField statuses. But now Viewer.viewingRoomsConnection is missing statuses so we added https://github.com/artsy/metaphysics/pull/2593.

In that last PR I have something I tried in the description that I will copy here.

I tried adding a test for inputFields include statuses, but I couldn't add this in an easy way.

I tried getting it by using something like getFieldsForTypeFromSchema but for inputFields, but there is no "type" that these are attached to.

I did find and try this which worked and gave me the whole schema basically. I'm sure we could use this in a test and get everything and them map it in an object that we can ask like Viewer.viewingRoomsConnection.inputFields includes statuses.

pvinis avatar Aug 07 '20 17:08 pvinis

@pvinis - at some point if the path is more fleshed out it would be good to add this to platform's JIRA board with a CLIENT-INFRA label, that way we can track it better. Issues in repos tend to get lost.

damassi avatar Aug 07 '20 17:08 damassi

I wasn't sure which board to throw that in. Thanks!

pvinis avatar Aug 07 '20 17:08 pvinis