Consolidate artwork bricks

[mzikherman]

We have a newer component used in several places, as well as an older component used in /collect, and a weirdly old and specific component used on /show pages.

Ideally we should use the same one.

[mzikherman]

Assigning u but feel free to also not. But it doesn't make sense for someone else to do this while you're making the other updates so i thought it might be good to assign u for now.

[broskoski]

Remembering the details of this now....

Any place that uses metaphysics for fetching uses the artwork_brick component, where previously we used the artwork_item component.

artwork_brick is used on..

• homepage rails
• artwork page "related artists" sections

artwork_item is used on

• /collect (surprisingly, though this one would be easy to switch over)
• any page with a show feed on it (namely /:artfair/browse )
• artist page filter
• gene page

There is also a third artwork brick used just in the show page called artwork_item_metaphysics, this one could also easily be ported over.

[broskoski]

To do

• [x] Rename artwork_filter_2
• [ ] Convert filter2 to use metaphysics
• [ ] Convert artwork_item_metaphysics to artwork_brick
• [ ] Convert commercial_filter to use artwork_brick

[sweir27]

Commenting here because there's an additional artwork component for auctions that will hopefully be able to deprecate the existing auction_artwork one. For now we thought it made sense to keep the auction component separate since it has fewer rules and the display is pretty different.

[briansw]

@broskoski don't forget the follows/favorites and works for you pages too.

[1aurabrown]

Hey, just wanted to link in this issue: https://github.com/artsy/force/issues/797 which I pr'd a fix for in the artwork metadata component only. The issue is beyond just the 'Not for sale' label, as the designs indicate that no sale message (whatever that message is) should be displayed when the work is or was part of an auction. I fixed this in the template, but if this is something we want to centralize this could happen in metaphysics. I didn't want to interfere with the consolidation that is already being undertaken, but to simply to make sure that it's not overlooked.

[alloy]

Performance (loading smaller images, I assume) is also a consideration for consolidation.

[briansw]

@broskoski @alloy just in case it's worth noting there's also the tag page artwork component.