force icon indicating copy to clipboard operation
force copied to clipboard

Client-side email address validation makes unhelpful suggestions.

Open alloy opened this issue 7 years ago • 6 comments

From #766.

In this example, the suggestion doesn’t include a TLD and using it would still not make the field validate, so it seems like an unhelpful suggestion. We use this across the site, so improving it touches many places.

alloy avatar Jan 25 '17 21:01 alloy

The library we use is https://github.com/mailcheck/mailcheck

alloy avatar Jan 25 '17 21:01 alloy

https://github.com/artsy/force/issues/754#issuecomment-275240048

kanaabe avatar Jan 25 '17 21:01 kanaabe

Copying @kanaabe's comment here https://github.com/mailcheck/mailcheck/issues/139

This definitely looks like the issue. A PR seems to have been up for 3 months.

Can someone npm instal from that person's branch and see if it indeed fixes the issue?

alloy avatar Jan 25 '17 23:01 alloy

@1aurabrown We should probably install mailcheck from the git repo and, if it does indeed fix the issue for us, ask the mailcheck maintainers to do a release with that fix.

alloy avatar Feb 10 '17 18:02 alloy

I installed from the latest commit from mailcheck, which includes that PR, and nothing seems to have changed

screen shot 2017-02-13 at 4 22 27 pm

1aurabrown avatar Feb 13 '17 15:02 1aurabrown

Should we switch or take ownership?

alloy avatar Feb 14 '17 16:02 alloy