force
force copied to clipboard
Client-side email address validation makes unhelpful suggestions.
From #766.
In this example, the suggestion doesn’t include a TLD and using it would still not make the field validate, so it seems like an unhelpful suggestion. We use this across the site, so improving it touches many places.
The library we use is https://github.com/mailcheck/mailcheck
https://github.com/artsy/force/issues/754#issuecomment-275240048
Copying @kanaabe's comment here https://github.com/mailcheck/mailcheck/issues/139
This definitely looks like the issue. A PR seems to have been up for 3 months.
Can someone npm instal from that person's branch and see if it indeed fixes the issue?
@1aurabrown We should probably install mailcheck from the git repo and, if it does indeed fix the issue for us, ask the mailcheck maintainers to do a release with that fix.
I installed from the latest commit from mailcheck, which includes that PR, and nothing seems to have changed
Should we switch or take ownership?