force icon indicating copy to clipboard operation
force copied to clipboard

Primary carousel on /galleries is not populated correctly when the city is provided directly in the URL

Open broskoski opened this issue 8 years ago • 7 comments

From @anandaroop on August 16, 2016 14:53

Compare

  1. Go to https://www.artsy.net/galleries
  2. Choose Rome from the city menu (this will cause the browser url to be rewritten)
  3. View the primary carousel

manual

…versus…

  1. Go to https://www.artsy.net/galleries?location=rome-italy
  2. View the primary carousel

url

Copied from original issue: artsy/force-private#5476

broskoski avatar Aug 16 '16 18:08 broskoski

From @anandaroop on August 16, 2016 14:55

Applies to /institutions as well

broskoski avatar Aug 16 '16 18:08 broskoski

From @starsirius on August 16, 2016 15:28

Yeah I believe we have logged the same issue here: https://github.com/artsy/force/issues/5143.

broskoski avatar Aug 16 '16 18:08 broskoski

From @starsirius on August 16, 2016 15:29

Going to close the other one since this is one is more clear. More context from the other issue:

https://github.com/artsy/force/blob/71ecb9148f1b3df5514585e3fc76dab3f8804487/apps/galleries_institutions/components/primary_carousel/fetch.coffee#L26

It will just use the location slug from the params (e.g. { type: 'institution', location: 'dallas-tx-usa' }).

broskoski avatar Aug 16 '16 18:08 broskoski

From @anandaroop on August 16, 2016 15:30

Ah, thanks! Janet noticed this today with Venice as the example.

broskoski avatar Aug 16 '16 18:08 broskoski

We can simply remove the blank carousel space for now as we are likely to redesign the gallery page experience.

tayapage6 avatar Apr 10 '17 21:04 tayapage6

I believe this was closed erroneously, and was just reported again in fact.

Will crosspost to Jira…

anandaroop avatar Jan 31 '19 19:01 anandaroop