force
force copied to clipboard
Primary carousel on /galleries is not populated correctly when the city is provided directly in the URL
From @anandaroop on August 16, 2016 14:53
Compare
- Go to https://www.artsy.net/galleries
- Choose Rome from the city menu (this will cause the browser url to be rewritten)
- View the primary carousel
…versus…
- Go to https://www.artsy.net/galleries?location=rome-italy
- View the primary carousel
Copied from original issue: artsy/force-private#5476
From @anandaroop on August 16, 2016 14:55
Applies to /institutions as well
From @starsirius on August 16, 2016 15:28
Yeah I believe we have logged the same issue here: https://github.com/artsy/force/issues/5143.
From @starsirius on August 16, 2016 15:29
Going to close the other one since this is one is more clear. More context from the other issue:
https://github.com/artsy/force/blob/71ecb9148f1b3df5514585e3fc76dab3f8804487/apps/galleries_institutions/components/primary_carousel/fetch.coffee#L26
It will just use the location slug from the params (e.g. { type: 'institution', location: 'dallas-tx-usa' }
).
From @anandaroop on August 16, 2016 15:30
Ah, thanks! Janet noticed this today with Venice as the example.
We can simply remove the blank carousel space for now as we are likely to redesign the gallery page experience.
I believe this was closed erroneously, and was just reported again in fact.
Will crosspost to Jira…