force icon indicating copy to clipboard operation
force copied to clipboard

[Do Not Merge] => chore(proxy): Delete all MP proxy code

Open damassi opened this issue 1 year ago • 3 comments

The type of this PR is: Chore

This PR solves DIA-833

⚠️ Lets wait to merge this for a couple of days to give folks a change to close old tabs

Description

Now that we have CloudFlare edge caching in place, we can remove this v1 cache proxy code!

Follow-up:

  • [ ] Remove ENABLE_GRAPHQL_PROXY env var
  • [ ] Remove ENABLE_GRAPHQL_CACHE env var

cc @artsy/diamond-devs

damassi avatar Sep 16 '24 19:09 damassi

#687 Bundle Size — 9.52MiB (-0.32%).

1875bd9(current) vs ffe4f84 main#484(baseline)

[!IMPORTANT] Bundle introduced 1 and removed 4 duplicate packages – View changed duplicate packages

[!WARNING] Bundle introduced 2 new packages: @sentry-internal/browser-utils, stylis – View changed packages

Bundle metrics  Change 9 changes Regression 1 regression Improvement 3 improvements
                 Current
#687
     Baseline
#484
Improvement  Initial JS 3.91MiB(-1.2%) 3.95MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 76.08% 2.04%
Change  Chunks 142(-0.7%) 143
Change  Assets 145(-0.68%) 146
Change  Modules 5663(+0.46%) 5637
Regression  Duplicate Modules 457(+0.44%) 455
Change  Duplicate Code 5.94%(+1.02%) 5.88%
Improvement  Packages 282(-3.09%) 291
Improvement  Duplicate Packages 39(-7.14%) 42
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#687
     Baseline
#484
Improvement  JS 9.28MiB (-0.31%) 9.31MiB
Improvement  Other 236.63KiB (-0.51%) 237.84KiB

Bundle analysis reportBranch damassi/chore/delete-proxy-coodeProject dashboard


Generated by RelativeCIDocumentationReport issue

relativeci[bot] avatar Sep 16 '24 19:09 relativeci[bot]

Trying this locally, and it seems like the app always attempts to connect to the cache, even when caching is disabled and no connection string is configured. This presents a problem for retiring the redis cluster previously used for Force's cache.

joeyAghion avatar Sep 23 '24 17:09 joeyAghion

👋 what's the status of this PR?

pam- avatar Oct 21 '24 18:10 pam-

Excellent question. There continues to be some requests (1-2k/hr) to the old /api/metaphysics proxying endpoint, but I think it's been long enough that we can comfortably remove it and "break" those clients. @damassi want to rebase and resolve conflicts?

joeyAghion avatar Oct 21 '24 19:10 joeyAghion

Will do 👍

damassi avatar Oct 21 '24 20:10 damassi