[Do Not Merge] => chore(proxy): Delete all MP proxy code
The type of this PR is: Chore
This PR solves DIA-833
⚠️ Lets wait to merge this for a couple of days to give folks a change to close old tabs
Description
Now that we have CloudFlare edge caching in place, we can remove this v1 cache proxy code!
Follow-up:
- [ ] Remove
ENABLE_GRAPHQL_PROXYenv var - [ ] Remove
ENABLE_GRAPHQL_CACHEenv var
cc @artsy/diamond-devs
#687 Bundle Size — 9.52MiB (-0.32%).
1875bd9(current) vs ffe4f84 main#484(baseline)
[!IMPORTANT] Bundle introduced 1 and removed 4 duplicate packages – View changed duplicate packages
[!WARNING] Bundle introduced 2 new packages: @sentry-internal/browser-utils, stylis – View changed packages
Bundle metrics
9 changes
1 regression
3 improvements
| Current #687 |
Baseline #484 |
|
|---|---|---|
3.91MiB(-1.2%) |
3.95MiB |
|
0B |
0B |
|
76.08% |
2.04% |
|
142(-0.7%) |
143 |
|
145(-0.68%) |
146 |
|
5663(+0.46%) |
5637 |
|
457(+0.44%) |
455 |
|
5.94%(+1.02%) |
5.88% |
|
282(-3.09%) |
291 |
|
39(-7.14%) |
42 |
Bundle size by type
2 changes
2 improvements
| Current #687 |
Baseline #484 |
|
|---|---|---|
9.28MiB (-0.31%) |
9.31MiB |
|
236.63KiB (-0.51%) |
237.84KiB |
Bundle analysis report Branch damassi/chore/delete-proxy-coode Project dashboard
Generated by RelativeCI Documentation Report issue
Trying this locally, and it seems like the app always attempts to connect to the cache, even when caching is disabled and no connection string is configured. This presents a problem for retiring the redis cluster previously used for Force's cache.
👋 what's the status of this PR?
Excellent question. There continues to be some requests (1-2k/hr) to the old /api/metaphysics proxying endpoint, but I think it's been long enough that we can comfortably remove it and "break" those clients. @damassi want to rebase and resolve conflicts?
Will do 👍