force icon indicating copy to clipboard operation
force copied to clipboard

feat: adds contextual banner when arriving with query params

Open dzucconi opened this issue 2 years ago • 1 comments

So I'm opening this but it's not ready to merge yet.

I dislike this PR for a few reasons.

  • This design doesn't feel well thought out: currently we have the top context bar that displays if the artwork is in a fair/show/auction. On top of that there's the cascading end times banner which shows up for some auctions. Now we're going to add this context specific banner based on the referrer (kind of) which displays a sort of context: that it's part of a gene's collection of artworks. This banner takes precedence over the cascading end times banner. TBH I almost feel like this would make more sense if we stacked a different colored banner or something. It's just weird.
  • On top of that there's not a well designed spec for banners with buttons in them: it blows the height out, making it taller than spec and just sits pretty awkwardly. The Figma specifies a component that is not within the design system, using larger text. This shouldn't be followed. We should probably expand the Banner to accept an action prop and then have a spec for what this should look like, across the board. (Notably, the FlashBanner component on the Homepage does this with email verification.)
  • From an implementation standpoint this feels brittle: we need to include query params in the OnboardingGene grid, which means we need to props drill an href into where it goes (it's another problem that grid items have two separate hrefs, but I digress). Then we need to check for those in the artwork app. OK — fine.

I just think there's an opportunity here to solve a larger problem, but I'm not sure what that problem is really — is it showing some context when you come from some referrers? Is it displaying Genes as part of the top context? Something else? Stacking banners? What other banners might show up on this page and how would we rank them?

dzucconi avatar Jul 15 '22 21:07 dzucconi