Network banner does not show when network connection is not present

[katarinabatina]

Put my phone into airplane mode, try to access home page but the yellow banner does not indicate to me that there are network issues.

[alloy]

So you’d want to see the yellow banner on top of the modal white ‘UNABLE TO LOAD’ view? I think that might be a bit much.

We are missing the banner on a failed artist follow btw: https://github.com/artsy/emission/issues/316

[katarinabatina]

@alloy Ah my mistake, I think in this case we're showing the wrong modal then as I believe we have one that says NO NETWORK CONNECTION

[alloy]

Ah I see, yeah that makes sense. Hmmm, it would require a bit more work, as detecting network reachability is not actually that simple, but it’s indeed doable 👍

[katarinabatina]

I don't think this is high priority for launch

[sarahscott]

We have a working banner in Inbox for this; is it worth a revisit? Perhaps a first task? @alloy

[alloy]

@sarahscott The problem is that this ticket is about any view in Eigen, not just React Native ones, so it would be more involved and require (objective-)C work.

[alloy]

Errrrrr, wait, that’s wrong, I thought this was the Eigen repo. Ok, yeah then we could do the same thing indeed 👍