eigen icon indicating copy to clipboard operation
eigen copied to clipboard

build(depsWIP): remove legacy jest-native dependency

Open gkartalis opened this issue 1 year ago • 3 comments

This PR resolves []

Description

Removes legacy @testing-library/jest-native matchers and replacing them with the @testing-library/react-native matchers.

Followed the migration guide from @testing-library/react-native.

PR Checklist

  • [x] I have tested my changes on iOS and Android.
  • [x] I hid my changes behind a feature flag, or they don't need one.
  • [x] I have included screenshots or videos, or I have not changed the UI.
  • [x] I have added tests, or my changes don't require any.
  • [x] I added an app state migration, or my changes do not require one.
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • remove legacy jest-native dependency - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

gkartalis avatar Jan 26 '24 09:01 gkartalis

This PR contains the following changes:

  • Dev changes (remove legacy jest-native dependency - gkartalis)

Generated by :no_entry_sign: dangerJS against ca09a98efc0fddb02591815f7e9ce9a246d8f80a

ArtsyOpenSource avatar Jan 26 '24 09:01 ArtsyOpenSource

lol, many tests fail ~ thought it was easier will timebox fixing them

gkartalis avatar Jan 26 '24 09:01 gkartalis

Most of the failing tests are due to using UNSAFE_ getBy or queryBy that are not supposed to work as selectors to assert on them for their props etc.

Next steps are to fix the remaining ones (and quick win out of that would be that we won't have anymore the not recommended UNSAFE_ methods anymore on our codebase

gkartalis avatar Jan 31 '24 12:01 gkartalis

closing and will revisit when I have more time

gkartalis avatar Feb 26 '24 16:02 gkartalis