eigen icon indicating copy to clipboard operation
eigen copied to clipboard

build(deps): remove iso8601 dep

Open brainbicycle opened this issue 2 years ago • 1 comments

This PR resolves []

Description

Removes iso8601 dep specified in podfile, there is a date formatter now built in foundation for the same purpose. We are still pulling in this dep as a transitive dep from Aerodramus but this gets us closer to getting rid of it.

Worth some focused testing! Live auctions and some api calls depend on this functionality! Draft until I do some testing :)

PR Checklist

  • [ ] I have tested my changes on iOS and Android.
  • [x] I hid my changes behind a feature flag, or they don't need one.
  • [x] I have included screenshots or videos, or I have not changed the UI.
  • [x] I have added tests, or my changes don't require any.
  • [x] I added an app state migration, or my changes do not require one.
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Remove iso8601 dep - Brian

Need help with something? Have a look at our docs, or get in touch with us.

brainbicycle avatar Oct 03 '23 16:10 brainbicycle

This PR contains the following changes:

  • Dev changes (Remove iso8601 dep - Brian)

Generated by :no_entry_sign: dangerJS against eab89c4150f295aad031602bcd9a0cf8c9f7ac88

ArtsyOpenSource avatar Oct 03 '23 16:10 ArtsyOpenSource