eigen icon indicating copy to clipboard operation
eigen copied to clipboard

fix(ux): dont ask notif permissions right after signin

Open pvinis opened this issue 1 year ago • 1 comments

Description

Right after signing, we ask for push notif permissions. this ux feels bad. I checked if we ask for permission before doing anything that needs it, and we do. So we don't need to ask up front so early. We will ask when the users needs it anyway.

We ask here:

  • https://github.com/artsy/eigen/blob/3ddbd6746cc233c1733b635c67c09319247b62f0/src/app/Scenes/SavedSearchAlert/helpers.ts#L22
  • https://github.com/artsy/eigen/blob/e09d9f37f46264bf08bf9a85519362e413007bf4/src/app/Scenes/MyProfile/MyProfilePushNotifications.tsx#L85

This PR resolves MOPLAT-175

QA Testing

Acceptance Criteria

Setup Instructions

PR Checklist

  • [ ] I tested my changes on iOS / Android.
  • [ ] I added screenshots or videos to illustrate my changes.
  • [ ] I added Tests and Stories for my changes.
  • [ ] I added an app state migration.
  • [ ] I hid my changes behind a feature flag.
  • [ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

pvinis avatar Sep 09 '22 04:09 pvinis

Warnings
:warning: Please only assign one person to a PR

Generated by :no_entry_sign: dangerJS against b2bcb3eb8d20bab259e6155d5e8ced16a69fb90e

artsy-peril[bot] avatar Sep 09 '22 04:09 artsy-peril[bot]

@pvinis should we close this PR for now following Joey's comments on slack?

MounirDhahri avatar Oct 14 '22 12:10 MounirDhahri

ive missed the comments. if you could link it to me that would be great 🙏

pvinis avatar Oct 17 '22 09:10 pvinis

Of course, here is it https://artsy.slack.com/archives/C01B2P6LJUU/p1662699539222859

MounirDhahri avatar Oct 17 '22 09:10 MounirDhahri