eigen icon indicating copy to clipboard operation
eigen copied to clipboard

[DONT MERGE, CLOSE AFTER RELEASE IS DONE] release 8.0.5 (no reanimated, cherry-picked the rest)

Open pvinis opened this issue 1 year ago • 6 comments

  • create initial step of merging autocomplete location

  • refactor LocationAutocomplete and remove styled

  • use LocationAutocomplete in the previous screens

ShippingModal, MyProfileEditForm, and SWA ArtworkDetailsForm

  • add UX enhancement in the edit profile screen

  • remove unused components

  • remove unneeded async

  • rename LocationAutocompleteInput to LocationAutocomplete

  • remove old tests and add new test

  • feat: allow custom input for location field

  • fix: update tests

  • feat: show error message when there are no results

  • updating tests
  • fix: use showError in the SWA flow

  • fix: update tests

  • fix: update show error logic

  • fix: update || to ??

Co-authored-by: Pavlos Vinieratos [email protected]

Co-authored-by: Pavlos Vinieratos [email protected]

Conflicts:

docs/troubleshooting.md

src/app/Components/DetailedLocationAutocomplete.tsx<!--

➡️ Use a PR title in the form of type(PROJECT-XXXX): what changed ➡️ Provide the Jira ticket in square brackets like [PROJECT-XXXX]

❗️ If this is a work in progress, remember to prefix it with [WIP] and/or open a draft PR instead of normal PR -->

Description

This PR resolves []

QA Testing

Acceptance Criteria

Setup Instructions

PR Checklist

  • [ ] I tested my changes on iOS / Android.
  • [ ] I added screenshots or videos to illustrate my changes.
  • [ ] I added Tests and Stories for my changes.
  • [ ] I added an app state migration.
  • [ ] I hid my changes behind a feature flag.
  • [ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

pvinis avatar Aug 12 '22 08:08 pvinis

all green. closing 👍.

pvinis avatar Aug 12 '22 08:08 pvinis

cc @rajsam003 @MounirDhahri

pvinis avatar Aug 12 '22 08:08 pvinis

Why did you closed this @pvinis ? we will need to keep pushing to it as we fix bugs right?

MounirDhahri avatar Aug 12 '22 08:08 MounirDhahri

Warnings
:warning: Please assign someone to merge this PR, and optionally include people who should review.

Hi there! :wave:

We're trialing semantic commit formatting which has not been detected in your PR title.

Refer to README#327 and Conventional Commits for PR/commit formatting guidelines.

Generated by :no_entry_sign: dangerJS against 48b8751e0a44cb09ed6b3e26ac1bc837d9e1cbb4

artsy-peril[bot] avatar Aug 12 '22 08:08 artsy-peril[bot]

duh 🤦, i forgot sorry haha. i thought its just for ci and we will open if we have bugs. but it makes sense to keep open.

pvinis avatar Aug 12 '22 08:08 pvinis

awesome. thanks a lot @pvinis 🙏

MounirDhahri avatar Aug 12 '22 08:08 MounirDhahri