eigen icon indicating copy to clipboard operation
eigen copied to clipboard

feat: improve otp login experience(enable password managers autofill)

Open gkartalis opened this issue 2 years ago • 2 comments

This PR resolves []

Description

Enables pasting otp with password managers on otp screen

Tested my changes on iOS and it works great.

iOS Demo

https://user-images.githubusercontent.com/21178754/169819892-896e0131-4d91-49cd-9d4e-e74f3ee3c352.mov

Can somebody with an android device confirm that this works also on android?

PR Checklist

  • [x] I tested my changes on iOS / Android.
  • [ ] I added screenshots or videos to illustrate my changes.
  • [ ] I added Tests and Stories for my changes.
  • [ ] I added an app state migration.
  • [ ] I hid my changes behind a feature flag.

To the reviewers 👀

  • [x] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • enable otp autofill from password managers - gkartalis

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

gkartalis avatar May 23 '22 10:05 gkartalis

@pvinis already tested on iOS and attached a video in the description, on android though looks like onepassword is not working properly either way so I was thinking to just remove the android specific line for now and leave it with the ios one, and we can follow up on why 1password fails to autofill in android in another pr

gkartalis avatar May 23 '22 12:05 gkartalis

I assigned myself too. George is on holidays and we talked about this ticket before he left, I'll take this over until then.

pvinis avatar May 29 '22 11:05 pvinis

closing this as it looks like autofill works on android now 💆‍♂️

gkartalis avatar Sep 15 '22 15:09 gkartalis