eigen icon indicating copy to clipboard operation
eigen copied to clipboard

chore: use externalID inside submit artwork flow

Open MounirDhahri opened this issue 1 year ago • 1 comments

This PR resolves []

Description

Sorry for the big PR, it wasn't possible to make this smaller.

This PR makes the required changes in order to use externalId instead of internalID for submissions. This required the following changes:

  • A migration to save the externalID instead of the submissionID.
  • Updating createOrUpdateSubmission to use the externaldID inside input
  • Updating the routes

https://github.com/user-attachments/assets/3d2a2e3d-39d5-4a49-920d-940c87594045

PR Checklist

  • [x] I have tested my changes on iOS and Android.
  • [x] I hid my changes behind a feature flag, or they don't need one.
  • [x] I have included screenshots or videos, or I have not changed the UI.
  • [x] I have added tests, or my changes don't require any.
  • [x] I added an app state migration, or my changes do not require one.
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • use externalID inside submit artwork flow - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

MounirDhahri avatar Aug 21 '24 10:08 MounirDhahri

This PR contains the following changes:

  • Cross-platform user-facing changes (use externalID inside submit artwork flow - mounir)

Generated by :no_entry_sign: dangerJS against 9884a94aefcc607c870eff711b1c20194b71852e

ArtsyOpenSource avatar Aug 21 '24 10:08 ArtsyOpenSource

Merging this to test things out since the beta is already available

MounirDhahri avatar Aug 30 '24 10:08 MounirDhahri