eigen icon indicating copy to clipboard operation
eigen copied to clipboard

fix: phone input component

Open MounirDhahri opened this issue 1 year ago • 0 comments

This PR resolves []

Description

This PR updates the phone input component to use proper masking and fixes the old slow/broken experience.

Changes made:

  • Update the list of phone countries and phone numbers to a more up to date one
  • Allow multiple masks per country
  • Fix performance issues related to mutation the re-injecting a mutated value
  • Bring back the skipped test
  • Use masks from palette-mobile Input component https://github.com/artsy/palette-mobile/pull/240

https://github.com/artsy/eigen/assets/11945712/b4146dc1-4a47-49a2-8b67-a905dbe73ef6

Next step:

  • Update this phone input component so it can be used everywhere.

PR Checklist

  • [x] I have tested my changes on iOS and Android.
  • [x] I hid my changes behind a feature flag, or they don't need one.
  • [x] I have included screenshots or videos, or I have not changed the UI.
  • [x] I have added tests, or my changes don't require any.
  • [x] I added an app state migration, or my changes do not require one.
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [X] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix phone input component - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

MounirDhahri avatar Jun 21 '24 10:06 MounirDhahri