eigen icon indicating copy to clipboard operation
eigen copied to clipboard

feat: phone number improvements

Open MounirDhahri opened this issue 1 year ago • 2 comments

This PR comes as a follow-up on this and this

Description

This PR makes the following improvements to the phone number

  • Add checkbox to ask users to save the number into their profile
  • Remove broken masking - which led to performance issues

PR Checklist

  • [ ] I have tested my changes on iOS and Android.
  • [ ] I hid my changes behind a feature flag, or they don't need one.
  • [ ] I have included screenshots or videos, or I have not changed the UI.
  • [ ] I have added tests, or my changes don't require any.
  • [ ] I added an app state migration, or my changes do not require one.
  • [ ] I have documented any follow-up work that this PR will require, or it does not require any.
  • [ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • save phone number to profile after submission - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

MounirDhahri avatar Jun 07 '24 09:06 MounirDhahri

This PR contains the following changes:

  • Cross-platform user-facing changes (save phone number to profile after submission - mounir)

Generated by :no_entry_sign: dangerJS against be3f7571217f300a9179a1b6448b19c6c152e9e8

ArtsyOpenSource avatar Jun 07 '24 09:06 ArtsyOpenSource

Unfortunately we need legal approval for this 😿 so we can't merge it.

MounirDhahri avatar Jun 07 '24 11:06 MounirDhahri