README
README copied to clipboard
chore: rfc pr template
Move the RFC templates from the ISSUE_TEMPLATE
subdir to PULL_REQUEST_TEMPLATE
.
i see the removals, but where is the addition? 🤔
oops, sorry about that
also, something to note.. github issues can have multiple templates. github pull requests cant. its one template for PRs and that's it.
Are we ok with the way these files are in that case? or do we wanna do a PR template that just points us to the RFC template to copy paste from? something else?
edit: https://github.blog/2018-01-25-multiple-issue-and-pull-request-templates/ seems like adding ?template=<the template>
might work. we can merge, and try it, and if it does, we can add a link with the template=RFC on the readme.md file.
looks like the idea of creating a PR from a link with template
param won't work because PR links need to specify a branch, e.g. /artsy/readme/compare/main...my-branch?quick_pull=1&template=issue_template.md
:(
I'm gonna move the templates to an innocuous subdir and reference them in the playbook
shall we merge this?
oh wow I'd forgotten about this