query-filter-bundle icon indicating copy to clipboard operation
query-filter-bundle copied to clipboard

SensioFrameworkExtraBundle is not maintained anymore

Open akalineskou opened this issue 2 years ago • 2 comments

https://symfony.com/blog/new-in-symfony-6-2-built-in-cache-security-template-and-doctrine-attributes

https://github.com/sensiolabs/SensioFrameworkExtraBundle

How can this library be migrated to the new attributes?

akalineskou avatar Dec 22 '22 17:12 akalineskou

Good question. I need to study the problem. I will check and get back here.

P. S. It'd be great if someone could have volunteered a pr, as I'm currently not an active user of php.

denisvmedia avatar Dec 23 '22 06:12 denisvmedia

I just removed the classes from my fork and the composer require (havent removed the tests or updated the readme) https://github.com/artprima/query-filter-bundle/compare/master...akalineskou:query-filter-bundle:master?expand=1

All my tests passed so everything still works the same (was not using them though in my case)

I would also remove them from this one, tag it as a new major version, and if someone was using the old annotation and query config they can be added in a new PR as new functionality

My guess would be that the ConfigConverter can be replaced with a custom value resolver https://symfony.com/doc/current/controller/value_resolver.html#adding-a-custom-value-resolver Not sure about the QueryFilter annotation

akalineskou avatar Dec 23 '22 12:12 akalineskou