artichoke icon indicating copy to clipboard operation
artichoke copied to clipboard

Remove dependency on mruby-*-ext mrbgems

Open lopopolo opened this issue 5 years ago • 8 comments

These implementations of Ruby core methods have been mostly buggy and not spec-compliant.

Use them as a starting point to implement them natively in Rust/evaled Ruby with the goal of passing ruby/spec.

  • [x] mruby-compar-ext
  • [x] mruby-enum-ext
  • [x] mruby-numeric-ext
  • [x] mruby-array-ext
  • [x] mruby-hash-ext
  • [x] mruby-range-ext
  • [ ] mruby-proc-ext
  • [x] mruby-symbol-ext
  • [x] mruby-object-ext
  • [x] mruby-kernel-ext
  • [ ] mruby-class-ext

lopopolo avatar Jul 08 '19 00:07 lopopolo

This change will allow eliminating dependency on mrbc which means:

  • we can null out the host build for mruby-sys.
  • no more dependency on gcc.

lopopolo avatar Aug 11 '19 21:08 lopopolo

I'm working on for mruby-enum-ext

tkbky avatar Aug 19 '19 22:08 tkbky

Sounds good thanks @tkbky

lopopolo avatar Aug 19 '19 23:08 lopopolo

picking up mruby-numeric-ext

tkbky avatar Aug 21 '19 23:08 tkbky

Thank you @tkbky

lopopolo avatar Aug 22 '19 04:08 lopopolo

Updated the checklist with the great work @tkbky has been doing. 💎 💪

lopopolo avatar Aug 25 '19 21:08 lopopolo

@tkbky has been making awesome progress on this ticket 🎉

lopopolo avatar Aug 31 '19 03:08 lopopolo

We can't yet remove mruby-proc-ext from mruby-sys/build.rs yet because mruby-method depends on it.

Originally posted by @tkbky in https://github.com/artichoke/artichoke/pull/217#issuecomment-526615816

lopopolo avatar Sep 01 '19 16:09 lopopolo