Arthur G.
Arthur G.
Thanks for checking my PR! > What if we fixed this by making sure that if a hero does not have a quote, we return nil instead of an error?...
hi @stefannibrasil. Sorry, completely forgot about this PR 😅 I'll remove heroes without quotes this week.
@stefannibrasil now thinking more about this, it's a bad idea to remove heroes that don't have quotes. I'm sure most users don't even use quotes from heroes, and having a...
From my perspective, as a Dota 2 player and developer, I would assume that if a library can generate Hero names, all heroes would be present. But in the other...
@stefannibrasil should be good to review :+1: