react-semantic-ui-datepickers icon indicating copy to clipboard operation
react-semantic-ui-datepickers copied to clipboard

Published 20 hours ago • verified publisher icon arthurdenner

issues#176 fix and minor improvements

Open modox94 opened this issue 3 years ago • 2 comments

What kind of change does this PR introduce?

https://github.com/arthurdenner/react-semantic-ui-datepickers/issues/176

What is the current behavior? Tests with errors. Locale cant be changed in ESM project. Deprecated addon in storybook.

What is the new behavior? Tests ok. Locale ok. Replaced addon for actual.

Checklist:

  • [x] Documentation
  • [x] Tests
  • [x] Ready to be merged

If there are any questions you can text me any time here https://t.me/crazynike94

modox94 avatar Aug 23 '22 23:08 modox94

Hi! I appreciate the interest but the proposed changes have the same issue pointed on previous attempts: It would cause all locales to be bundled with the library. Apologies for not having the time to look into this library but I'd rather not push this change forward now.

arthurdenner avatar Sep 01 '22 12:09 arthurdenner

Hi, thanks for the answer. I have rewrote logic of localization import, maybe branch is ready for merging now. This branch have breaking changes now, so users to have change code after updating package.

modox94 avatar Sep 09 '22 04:09 modox94