react-semantic-ui-datepickers icon indicating copy to clipboard operation
react-semantic-ui-datepickers copied to clipboard

Remove outer div (fixes #19)

Open alexrsagen opened this issue 3 years ago • 5 comments

What kind of change does this PR introduce?

  • Adds properties width and fieldClassName to the <SemanticDatepicker> element, forwarding them in addition to the existing properties disabled, error, inline, required to the existing <Form.Field> element.
  • Wraps the <Form.Field> element with a <Ref> element, to set the ref this.el on the <Form.Field> element
  • Sets position: relative CSS on the existing <Form.Field> element
  • Removes the outer div

What is the current behavior? You cannot set className or width on the inner <Form.Field> element.

What is the new behavior? You can now set className or width on the inner <Form.Field> element.

There is also one less <div> in the DOM, which is nice.

Checklist:

  • [x] Documentation
  • [x] Tests
  • [x] Ready to be merged

I'm not quite sure if there are any additional steps needed before merging this, so I am requesting a review before anything is merged.

alexrsagen avatar Feb 14 '22 11:02 alexrsagen

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/AVs7giEbj7ZGyQrVDNRTNfH2S5we
✅ Preview: https://react-semantic-ui-datepickers-git-fork-kons-79c053-arthurdenner.vercel.app

vercel[bot] avatar Feb 14 '22 11:02 vercel[bot]

@arthurdenner This should resolve #26 in an ideal way as well, since you can set the semantic <Form.Field> property width directly, right?

Hoping to get this merged and released ASAP. Thanks for your (and all the other contributors) hard work on this datepicker 😄

alexrsagen avatar Feb 14 '22 11:02 alexrsagen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 17 '22 06:04 stale[bot]

When is this being rolled into the main branch?

bmartin1134 avatar Jan 25 '23 19:01 bmartin1134

I'm also keen to see this PR merged. Any updates?

jatls avatar Feb 11 '23 21:02 jatls