react-semantic-ui-datepickers
react-semantic-ui-datepickers copied to clipboard
Remove outer div (fixes #19)
What kind of change does this PR introduce?
- Adds properties
widthandfieldClassNameto the<SemanticDatepicker>element, forwarding them in addition to the existing propertiesdisabled,error,inline,requiredto the existing<Form.Field>element. - Wraps the
<Form.Field>element with a<Ref>element, to set the refthis.elon the<Form.Field>element - Sets
position: relativeCSS on the existing<Form.Field>element - Removes the outer div
What is the current behavior?
You cannot set className or width on the inner <Form.Field> element.
What is the new behavior?
You can now set className or width on the inner <Form.Field> element.
There is also one less <div> in the DOM, which is nice.
Checklist:
- [x] Documentation
- [x] Tests
- [x] Ready to be merged
I'm not quite sure if there are any additional steps needed before merging this, so I am requesting a review before anything is merged.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/AVs7giEbj7ZGyQrVDNRTNfH2S5we
✅ Preview: https://react-semantic-ui-datepickers-git-fork-kons-79c053-arthurdenner.vercel.app
@arthurdenner This should resolve #26 in an ideal way as well, since you can set the semantic <Form.Field> property width directly, right?
Hoping to get this merged and released ASAP. Thanks for your (and all the other contributors) hard work on this datepicker 😄
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
When is this being rolled into the main branch?
I'm also keen to see this PR merged. Any updates?