pan-globalprotect-okta icon indicating copy to clipboard operation
pan-globalprotect-okta copied to clipboard

Don't try to split a tuple for debug output

Open keis opened this issue 2 years ago • 4 comments

Add tuple to the list of types that should not be split()

keis avatar Jan 27 '22 09:01 keis

LGTM. Anyhow, can You elaborate in what situation this happens?

arthepsy avatar Jan 27 '22 10:01 arthepsy

It happens when trying to use webauthn with debug on

!!! Touch the flashing U2F device to authenticate... !!!
Traceback (most recent call last):
  File "/home/keis/src/github.com/arthepsy/pan-globalprotect-okta/./gp-okta.py", line 660, in okta_mfa_webauthn
    dbg(conf.debug, 'assertion.result', result)
  File "/home/keis/src/github.com/arthepsy/pan-globalprotect-okta/./gp-okta.py", line 130, in dbg
    for line in x.split('\n'):
AttributeError: 'tuple' object has no attribute 'split'

This is with fido2==0.7.0 so before the API change that's mentioned in #33

keis avatar Jan 27 '22 11:01 keis

@arthepsy: That change is good. It's useful for #33 but unrelated.

coldcoff avatar Jan 28 '22 09:01 coldcoff

@arthepsy -- please merge.

coldcoff avatar Mar 14 '22 08:03 coldcoff